Skip to content

moved email message to & cc names to config file #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexmerlin merged 7 commits into from
Jan 31, 2025
Merged

moved email message to & cc names to config file #538

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a998953
moved email message to & cc names to config file
Jurj-Bogdan Jan 29, 2025
b465ae6
phpcs fix
Jurj-Bogdan Jan 29, 2025
a853945
implemented dot-navigation package
MarioRadu Jan 31, 2025
7962a7e
implemented dot-navigation package
MarioRadu Jan 31, 2025
a15e796
requested changes
Jurj-Bogdan Jan 31, 2025
9cf4c46
included missing key in dist file
Jurj-Bogdan Jan 31, 2025
2d13d4c
keys changed
Jurj-Bogdan Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions config/autoload/local.php.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,11 @@ return [
'contact' => [
'notification_receivers' => [],
'message_receivers' => [
Copy link
Member

@arhimede arhimede Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the string 'receiver'.
In email world, the standard string is 'recipients'
At least for me , 'receiver' is confusing
@alexmerlin your opionion ?

Copy link
Member Author

@Jurj-Bogdan Jurj-Bogdan Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idea might be dropping the "contact" key from local.php altogether, as the only part it's used by default is the sendContactMail function in MessageService.php.

That function already uses the config file from dot-mail (mail.global.php) for the "addFrom" method, and that has the to and cc keys available as well.

Copy link
Member

@arhimede arhimede Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idea might be dropping the "contact" key from local.php altogether, as the only part it's used by default is the sendContactMail function in MessageService.php.

That function already uses the config file from dot-mail (mail.global.php) for the "addFrom" method, and that has the to and cc keys available as well.

Let' discuss tomorrow
as i do not like either the line from MessageService.php
$this->config['contact']['message_receivers']['to'],
$this->config['contact']['message_receivers']['cc'],

'to' => [
'name' => 'Dotkernel Team',
'to' => [
'[email protected]',
],
'cc' => [
'cc' => [
'[email protected]',
],
],
Expand Down
4 changes: 2 additions & 2 deletions src/Contact/src/Service/MessageService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ public function sendContactMail(Message $message): bool
);
$this->mailService->getMessage()->addTo(
$this->config['contact']['message_receivers']['to'],
'Dotkernel Team'
$this->config['contact']['message_receivers']['name']
);
$this->mailService->getMessage()->addCC(
$this->config['contact']['message_receivers']['cc'],
'Dotkernel Team'
$this->config['contact']['message_receivers']['name']
);
$this->mailService->getMessage()->setReplyTo($message->getEmail(), $message->getName());

Expand Down
5 changes: 3 additions & 2 deletions test/Unit/Contact/Service/MessageServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ public function testProcessMessage(): void
[
'contact' => [
'message_receivers' => [
'to' => '[email protected]',
'cc' => '[email protected]',
'to' => '[email protected]',
'cc' => '[email protected]',
'name' => 'Dotkernel Team',
],
],
'dot_mail' => [
Expand Down