Fix membership calculation

[brage-andreas]

This PR fixes two bugs that were causing students to be assigned a start year 1 year later than reality (e.g., 2024 instead of 2023).

Fix loop overwrite in empty semesters

The logic for estimating progress during empty semesters (like bachelor semester 4) was flawed. We iterated through all previous semesters to guess the current year, but we were overwriting the result in every iteration. Now we Math#max the current and local values to find the highest instead.

Fix off-by-one rounding error

We were converting semesters to years using Math.floor(semester / 2). This failed for spring semesters.

Example: semester 3 (spring of 2nd year) became floor(1.5) = 1. This made the system think 2nd-year students were only in their 1st year.

This is fixed by changing it to Math.round(semester / 2), so that semester 3 correctly resolves to 2 years.

[brage-andreas]

• Add study grade calculation tests #2773
• Add membership calculation tests #2772
• Fix membership calculation #2771 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[brage-andreas]

Merge activity

• Jan 23, 12:05 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jan 23, 12:05 AM UTC: @brage-andreas merged this pull request with Graphite.