ROPC remediation - configuration/index.md, use-http-context.md, new include file #33858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdykstra
commented
Oct 17, 2024
tdykstra
requested review from
Rick-Anderson
and removed request for
Rick-Anderson
Rick-Anderson
suggested changes
Oct 23, 2024
| * Never store passwords or other sensitive data in configuration provider code or in plain text configuration files. The [Secret Manager](xref:security/app-secrets) tool can be used to store secrets in development. | ||
| * Don't use production secrets in development or test environments. | ||
| * Specify secrets outside of the project so that they can't be accidentally committed to a source code repository. | ||
| * Avoid the use of passwords in production apps; for more information, see [Secure authentication flows](xref:security/index#secure-authentication-flows). |
tdykstra
commented
Oct 28, 2024
Co-authored-by: Tom Dykstra <[email protected]>
Rick-Anderson
approved these changes
Oct 28, 2024
Rick-Anderson
previously requested changes
Oct 28, 2024
Contributor
Rick-Anderson
left a comment
Rick-Anderson
left a comment
There was a problem hiding this comment.
Fix
avoid the use of passwords in production apps
tdykstra
commented
Oct 29, 2024
Contributor
Author
Fixed. I forgot it was also in the 6 and 7 includes. |
tdykstra
dismissed
Rick-Anderson’s stale review
Fixed the text that the review asked to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33860
Contributes to #33757
Internal previews