ROPC remediation - more files with connection strings #33990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdykstra
changed the title
tdykstra
changed the title
tdykstra
changed the title
tdykstra
commented
Oct 31, 2024
Contributor
Author
There was a problem hiding this comment.
Including password here isn't required, as it and the other parts of the connection string were there just to give an impression of what an Azure Redis Cache connection string looks like.
tdykstra
changed the title
tdykstra
changed the title
Rick-Anderson
approved these changes
Nov 1, 2024
|
|
||
| ```dotnetcli | ||
| dotnet user-secrets set "DbPassword" "pass123" | ||
| dotnet user-secrets set "DbPassword" "`<secret value>`" |
Contributor
There was a problem hiding this comment.
For bonus points, replace "<secret value>"
with
"\x00``<secret value>``\" which should throw an error, although maybe <secret value> will throw. We don't want them copy/paste something that works.
| [!code-json[](~/security/app-secrets/samples/3.x/UserSecrets/appsettings-unsecure.json?highlight=3)] | ||
|
|
||
| A more secure approach is to store the password as a secret. For example: | ||
| Storing passwords in plain text is insecure. For example, a database connection string stored in `appsettings.json` should not include a password. Instead, store the password as a secret, and include the password in the connection string at runtime. For example: |
Contributor
There was a problem hiding this comment.
do you want to tell them never store secrets in a config file (for example appsettings.json) ... checked in source.
tdykstra
commented
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33991
Internal previews