Skip to content

Conversation

@guardrex guardrex self-assigned this Nov 5, 2024
@guardrex
Copy link
Collaborator

guardrex commented Nov 5, 2024

The Blazor link changes require a few updates. I'll get to it ASAP 🏃‍♂️ (as suggestions on this PR).

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Daidihuang ... I've updated the Blazor links. I'm going to go ahead and commit them now. I'll take care of that one in the progressive Blazor app article (Line 125) on that other issue that I opened.

@guardrex guardrex removed their assignment Nov 5, 2024
@guardrex
Copy link
Collaborator

guardrex commented Nov 5, 2024

BTW @Daidihuang ... Are you a vendor or a community dev? Either way, I suppose that you'll need to accept the Contributor License Agreement. Otherwise, we won't be able to merge this PR.

If you are a vendor, I recommend updating your GH profile to indicate it.

@Daidihuang
Copy link
Contributor Author

Daidihuang commented Nov 5, 2024 via email

@Daidihuang
Copy link
Contributor Author

Daidihuang commented Nov 5, 2024 via email

@Daidihuang
Copy link
Contributor Author

Daidihuang commented Nov 5, 2024 via email

@Daidihuang Daidihuang marked this pull request as ready for review November 5, 2024 19:09
Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rick-Anderson ... I think this is fine now. I'll work on the one more-complicated Blazor link as soon as my Internet is back up. I'll leave this to u for a final check and merge.

@guardrex
Copy link
Collaborator

guardrex commented Nov 6, 2024

@Rick-Anderson ... I'll go ahead with this to unblock the other issue that I opened.

@guardrex guardrex merged commit a7b906b into dotnet:main Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants