-
Notifications
You must be signed in to change notification settings - Fork 25.1k
[Blazor] Security - Server - Additional security abstractions section rework #34056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok, I might be done messing around with it. 😄 Notes ...
Look the changes over and see what you think. 👂 |
hakenr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'll try to keep the language-related instructions you provided in mind (like using contractions, etc.). Unfortunately, since I'm not a native speaker, you'll always need to polish my changes.
|
You're doing a fantastic job with English, and I ... and I'm sure Dan and Artak ... greatly appreciate your contributions. I frequently mention your PRs to them offline, and I'm confident that you're receiving ongoing MVP support, which they take a direct hand in each year for renewals. I think we have hundreds of company-wide and repo-wide writing guidelines, various enforced rules and lightly-enforced general conventions, many of them unpublished 😢. I asked several years ago if I could write an article on these rules and conventions, but it was shot down by management 😢. |
These classes aren't abstractions in the usual sense (e.g., as used in dependency injection). In the source code,
ServerAuthenticationStateProvideris used as the default implementation registered byAddRazorComponents()andAddServerSideBlazor().RevalidatingServerAuthenticationStateProvideris a base class designed to support revalidating implementations likeIdentityRevalidatingAuthenticationStateProvider.I removed the paragraph explaining how to change the revalidation interval, as it was an unnecessary detail here and referenced a dead link.
Internal previews