Skip to content

Conversation

@hakenr
Copy link
Member

@hakenr hakenr commented Nov 7, 2024

These classes aren't abstractions in the usual sense (e.g., as used in dependency injection). In the source code, ServerAuthenticationStateProvider is used as the default implementation registered by AddRazorComponents() and AddServerSideBlazor(). RevalidatingServerAuthenticationStateProvider is a base class designed to support revalidating implementations like IdentityRevalidatingAuthenticationStateProvider.

I removed the paragraph explaining how to change the revalidation interval, as it was an unnecessary detail here and referenced a dead link.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/security/server/index.md aspnetcore/blazor/security/server/index

@hakenr hakenr requested a review from guardrex as a code owner November 7, 2024 01:26
@guardrex
Copy link
Collaborator

guardrex commented Nov 7, 2024

Ok, I might be done messing around with it. 😄

Notes ...

  • We usually use contractions.
  • I elevated the "when" clause to an essential clause (i.e., it's a required qualifier for the statement) by removing the comma.
  • The localization team has us trying to avoid the use of gerunds ("-ing"-ending words) in section headings. They told us that they don't translate well. We do use them for common terms, such as "logging," but we avoid them when we can. I think we can go with "Additional" there.
  • Let's keep a remark on the RevalidationInterval but roll it into the bullet point. I fixed the link for the example implementation. BTW - They dropped the release/7.0 branch, and I have an open issue to fix the handful of 7.0 links around the repo. I'll take care of that this morning.

Look the changes over and see what you think. 👂

@guardrex guardrex self-assigned this Nov 7, 2024
Copy link
Member Author

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I'll try to keep the language-related instructions you provided in mind (like using contractions, etc.). Unfortunately, since I'm not a native speaker, you'll always need to polish my changes.

@guardrex
Copy link
Collaborator

guardrex commented Nov 7, 2024

You're doing a fantastic job with English, and I ... and I'm sure Dan and Artak ... greatly appreciate your contributions. I frequently mention your PRs to them offline, and I'm confident that you're receiving ongoing MVP support, which they take a direct hand in each year for renewals.

I think we have hundreds of company-wide and repo-wide writing guidelines, various enforced rules and lightly-enforced general conventions, many of them unpublished 😢. I asked several years ago if I could write an article on these rules and conventions, but it was shot down by management 😢.

@guardrex guardrex merged commit e0952be into dotnet:main Nov 7, 2024
3 checks passed
@hakenr hakenr deleted the patch-37 branch November 7, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants