Skip to content

Conversation

@hakenr
Copy link
Member

@hakenr hakenr commented Nov 7, 2024

@hakenr hakenr requested a review from guardrex as a code owner November 7, 2024 23:54
@guardrex
Copy link
Collaborator

guardrex commented Nov 8, 2024

This is OK 👍. It's markdown for superscript.

@guardrex guardrex closed this Nov 8, 2024
@hakenr
Copy link
Member Author

hakenr commented Nov 8, 2024

@guardrex Maybe, but it’s not supported by the docs platform:

image

Should we replace it with <sup>2</sup>?

@guardrex
Copy link
Collaborator

guardrex commented Nov 8, 2024

I see. I'll report that to them.

Yes, please make that change.

@guardrex guardrex reopened this Nov 8, 2024
@guardrex guardrex self-assigned this Nov 8, 2024
Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found out that CommonMark's management refused to support superscript/subscript markdown syntax. HTML is the right approach.

I searched the repo, and this is the only spot to fix.

Thanks again!

@guardrex guardrex merged commit 54bd9c5 into dotnet:main Nov 8, 2024
3 checks passed
@hakenr
Copy link
Member Author

hakenr commented Nov 8, 2024

I hope this won't break the PDF export.

@guardrex
Copy link
Collaborator

guardrex commented Nov 8, 2024

It should fully support HTML. 🤞🍀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants