ROPC: dotnet publish /2 #34114
Merged
ROPC: dotnet publish /2 #34114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdykstra
approved these changes
Nov 18, 2024
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
LGTM, just a few comments.
| /p:Username={USERNAME} | ||
| /p:Password={PASSWORD} | ||
| ``` | ||
| <!-- As of Nov 2024 |
Contributor
There was a problem hiding this comment.
Why is this commented out?
Contributor
Author
There was a problem hiding this comment.
That's internal for us to test fetching PW. I don't want publish how to get and save the pw, it's not hard to figure out.
|
|
||
| > [!IMPORTANT] | ||
| > The `dotnet msbuild` command is a cross-platform command and can compile ASP.NET Core apps on macOS and Linux. However, MSBuild on macOS and Linux isn't capable of deploying an app to Azure or other MSDeploy endpoints. | ||
| Delete the RG or restore the basic auth settings to disabled. |
Contributor
There was a problem hiding this comment.
I presume RG is resource group, but if that isn't explained anywhere in the text, it would be worthwhile to add it.
Co-authored-by: Tom Dykstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33861
Fixes #30013
Fixes #33759
Fixes #24852
Fixes #32721
Fixes #34131
I removed most information found in Microsoft.NET.Sdk.Publish, Overview of Visual Studio Publish and
MSBuild
Internal previews