-
Notifications
You must be signed in to change notification settings - Fork 25.1k
2FA/TOTP coverage for WASM+Identity #34189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
df05640
2FA/TOTP coverage for WASM+Identity
guardrex 1a76a33
Updates
guardrex f11cb7e
Updates
guardrex 732f927
Updates
guardrex 8f12c38
Updates
guardrex 7310d53
Updates
guardrex 22cbd85
Updates
guardrex ef67733
Updates
guardrex 19f22b9
Updates
guardrex e67b8a8
Updates
guardrex 8e328eb
Updates
guardrex 8dfe0bb
Updates
guardrex 5a80e7e
Updates
guardrex e3d87d3
Apply suggestions from code review
guardrex 22f2568
Updates
guardrex c1e2bd8
Updates
guardrex d716300
Updates
guardrex 6060ce8
Updates
guardrex c128164
Apply suggestions from code review
guardrex 5025c32
Updates
guardrex e57702c
Updates
guardrex 17be3fb
Updates
guardrex 0be9c72
Updates
guardrex 9c5525e
Updates
guardrex 7d71141
Updates
guardrex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a new go.microsoft.com link that points to this Blazor QR code generation docs? It would be nice to update the Blazor Identity project template and scaffolding to point to this instead. Maybe we could remove
<div></div><div data-url="@authenticatorUri"></div>while we're at it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danroth27 cc @guardrex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we need to change the current filename/URL, the GO link destination will be ...