Remove Nowin WebSocket sample #34221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guardrex
approved these changes
Nov 27, 2024
Collaborator
guardrex
left a comment
guardrex
left a comment
There was a problem hiding this comment.
I'll leave it to Rick to merge, given that he worked on the original issue/PR.
Rick-Anderson
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would prefer to revert #19693, because by moving the Nowin sample, we removed any documentation on how to run ASP.NET Core using an OWIN server. But if we decide that isn't an important enough scenario to still document, since we don't know of any supported OWIN servers that run outside of .NET Framework, the "Run ASP.NET Core on an OWIN-based server and use its WebSockets support" section makes no sense. All it shows is bog standard WebSocket code. The only thing interesting about it was the code to make it work on Nowin which is thankfully still in the sample directory.
Internal previews