Update bootstrap.bundle.js #34222
Merged
Update bootstrap.bundle.js #34222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@guardrex - Can you review and merge if approved? thanks |
guardrex
approved these changes
Nov 27, 2024
Collaborator
guardrex
left a comment
guardrex
left a comment
There was a problem hiding this comment.
Yes, @v-thepet, we can change it. Note in passing that Bootstrap isn't a MS product, and it's in their source code ...
https://github.com/twbs/bootstrap/blob/v4.3.1/dist/js/bootstrap.bundle.js#L1505
The good news is that they don't have this license remark with that word in their latest versions of this file. It shouldn't crop up again with future sample apps that use Bootstrap.
The article and sample was created by @damienbod with @Rick-Anderson as the MS author. v4.3.1 is fairly old. The current version is 5.3.3. Idk if they'll want to schedule a Bootstrap update for the sample app at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Policheck bug https://dev.azure.com/msft-skilling/learn-platform-policheck/_workitems/edit/345733