Skip to content

Conversation

@hakenr
Copy link
Member

@hakenr hakenr commented Dec 3, 2024

  1. When I think back to what wasn’t entirely clear to me and I had to test and look up in the source code - the whole condition for primitive types in change detection applies to the parameters used (set) in a specific place, not to the component having non-primitive parameters.
  2. Starting net9 EventCallbacks are included in change detection.

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/performance.md ASP.NET Core Blazor performance best practices

@hakenr hakenr requested a review from guardrex as a code owner December 3, 2024 23:12
@hakenr hakenr marked this pull request as draft December 3, 2024 23:13
@hakenr hakenr marked this pull request as ready for review December 3, 2024 23:18
@guardrex guardrex self-assigned this Dec 3, 2024
Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a couple of NIT suggestions.

One more thing ... can you move the lead-in sentence outside of the bullet list?

To prevent rendering recursion into a particular subtree, use either of the following approaches:

Move that ☝️ to one line above the first moniker-range.

@hakenr
Copy link
Member Author

hakenr commented Dec 3, 2024

All your suggestions should be resolved now.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@guardrex guardrex merged commit 45bd545 into dotnet:main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants