-
Notifications
You must be signed in to change notification settings - Fork 25.1k
replace source links with API doc links /4/m2 #34490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ## Subset of .NET APIs for Blazor WebAssembly apps | ||
|
|
||
| A curated list of specific .NET APIs that are supported on the browser for Blazor WebAssembly isn't available. However, you can manually [search for a list of .NET APIs annotated with `[UnsupportedOSPlatform("browser")]`](https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/Runtime/Versioning/PlatformAttributes.cs,34041602e232c616,references) to discover .NET APIs that aren't supported in WebAssembly. | ||
| A curated list of specific .NET APIs that are supported on the browser for Blazor WebAssembly isn't available. However, you can manually <!--keep--> [search for a list of .NET APIs annotated with `[UnsupportedOSPlatform("browser")]`](https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/Runtime/Versioning/PlatformAttributes.cs,34041602e232c616,references) to discover .NET APIs that aren't supported in WebAssembly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add <!--keep--> to
exclude from search using ^(?=.*https:\/\/source\.dot\.net)(?!.*--keep--).*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the criteria you're using to decide which ones remain as source links? That seems a little risky since the links are not going to Main, the code they show will soon get out of sync with the current state of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was kept because the source browser makes it easy to spot these APIs that have the [UnsupportedOSPlatform("browser")] attribute on them via a filtered cross-link. AFAIK, I have XREF for everything else.
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions.
aspnetcore/fundamentals/error-handling/includes/error-handling8.md
Outdated
Show resolved
Hide resolved
…8.md Co-authored-by: Luke Latham <[email protected]>
Fixes #30158
PR brings 59 hits down to 26 in 10 files
Internal previews
Toggle expand/collapse