Skip to content

Call WebApplication.CreateBuilder(args) only once #34492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Call WebApplication.CreateBuilder(args) only once #34492

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9739858
Call WebApplication.CreateBuilder(args) only once
tdykstra Jan 14, 2025
c74f324
Fix casing and punctuation in important note
tdykstra Jan 14, 2025
5f6106f
Update aspnetcore/fundamentals/configuration/index.md
tdykstra Jan 16, 2025
73b176a
Update aspnetcore/fundamentals/configuration/index.md
tdykstra Jan 20, 2025
b5872ae
Add comment -- delete this note in .NET 10 version of the doc.
tdykstra Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions aspnetcore/fundamentals/configuration/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ var builder = WebApplication.CreateBuilder(args);
1. [appsettings.json](#appsettingsjson) using the [JSON configuration provider](#jcp).
1. A fallback to the host configuration described in the [next section](#host).

Note: `WebApplication.CreateBuilder(args)` should only be called once.
Copy link
Contributor

@Rick-Anderson Rick-Anderson Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: `WebApplication.CreateBuilder(args)` should only be called once.

Many of our docs use the same API many times, for example app.UseCors `https://learn.microsoft.com/en-us/aspnet/core/security/cors

Copy link
Contributor Author

@tdykstra tdykstra Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link we originally had here tells why you don't want to call this API multiple times but people tend to think it can or needs to be. Perhaps it would be good to put the link back in?
https://techcommunity.microsoft.com/blog/iis-support-blog/asp-net-core-503-server-has-been-shutdown/3830338

Copy link
Contributor

@Rick-Anderson Rick-Anderson Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure


<a name="host"></a>

### Default host configuration sources
Expand Down
Loading