Kestrel named pipes /n/1 #34640
Merged
Kestrel named pipes /n/1 #34640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JamesNK please review these changes CoPilot made to your code. |
Rick-Anderson
commented
Feb 4, 2025
|
|
||
| ### Customize Kestrel named pipe endpoints | ||
|
|
||
| Kestrel's named pipe support includes advanced customization options. The [CreateNamedPipeServerStream](/dotnet/api/microsoft.aspnetcore.server.kestrel.transport.namedpipes.namedpipetransportoptions.createnamedpipeserverstream) property on the named pipe options allows pipes to be customized per-endpoint. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
@JamesNK pls review |
Member
|
The code sample isn't complete in the preview:
The bottom Can you suggest working code? I left the configuration to the reader. I could add a comment saying as much or you can provide working code. |
JamesNK
requested changes
Feb 26, 2025
| options.CreateNamedPipeServerStream = (context) => | ||
| { | ||
| var pipeSecurity = CreatePipeSecurity(context.NamedPipeEndpoint.PipeName); | ||
| var pipeOptions = PipeOptions.None; // Essential! |
Member
There was a problem hiding this comment.
This pipeOptions variable isn't used anywhere
JamesNK
reviewed
Mar 4, 2025
JamesNK
reviewed
Mar 4, 2025
JamesNK
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33455
Internal review URL --> Customize Kestrel named pipe endpoints
Internal previews