YARP migration /2 #34657
Merged
YARP migration /2 #34657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsp-msft
approved these changes
Feb 6, 2025
|
|
||
| ## Example | ||
|
|
||
| ``` |
Member
There was a problem hiding this comment.
Should these code blocks have ```csharp so the syntax highlighting is correct?
Contributor
Author
There was a problem hiding this comment.
yes, next pass. This pass is to get a clean build. The PR merges into a staging branch.
Contributor
Author
There was a problem hiding this comment.
Should these code blocks have ```csharp so the syntax highlighting is correct?
Ultimately, we'll move all the code snippets to project files and import the code. That way we can make sure they compile. That allows highlights too.
| @@ -0,0 +1,128 @@ | |||
| # Packages referenced by YARP | |||
Member
There was a problem hiding this comment.
This doesn't seem like it needs to be in these docs. We can continue to keep it in the repo somewhere.
Rick-Anderson
commented
Feb 6, 2025
MihaZupan
reviewed
Feb 6, 2025
Rick-Anderson
added a commit
that referenced
this pull request
Feb 10, 2025
* YARP migration /2 (#34657) * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * YARP migration /2 * Yarb pass 2 (#34667) * Yarb pass 2 * Yarb pass 2 * fix * fix * fix * fix * YARP owner (#34675) * YARP owner * YARP owner * Yarp/Stage to main /2 * Yarp/Stage to main /2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #34650
Internal preview URL
Internal previews
Toggle expand/collapse
Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.