-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Reconnect UI component #34842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconnect UI component #34842
Conversation
|
Sorry for keeping you waiting for the review. I first want to investigate and fix https://github.com/dotnet/AspNetCore-ManualTests/issues/3489 because it might involve changing some things mentioned in the docs. |
|
Thanks @oroztocil ... I'll work on this now and ping you back on the next commit. |
|
@oroztocil ... I retained the table, collapsed some of duplicate coverage a bit for the event, but I also split out the extended explanations to paragraphs under the table. I moved the |
|
... and @oroztocil ... see my questions in my OP ☝️. The first question is important on retaining the current images. The second question might not be something that we need in the coverage ... it could just be something simple that I don't understand. |
|
@guardrex To answer your questions:
|
I see ... yeah ... I think that's logical from reading the code. You can let me know if you think we should have remark about it at the end of the section. |
|
@oroztocil ... Is this getting better or WORSE? 😆 It looks like we should show example code for wiring up the event, so I added a simplified example. Also, note that I did state the default for the .NET CLI ...
... but not for VS because IIRC 🤔 VS remembers the last app setup ... so Server/Auto isn't really a "default" for VS IIRC. Let me know if I'm wrong about that. |
oroztocil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good now 🙂 I'd say this piece of functionality is inherently a bit difficult to document. (And I guess I should have written some summary of how the entire thing works to make it less confusing from the start.)
|
No worries ... that's ok. It perhaps saved a little of your time for me to take a stab at it and just fix my poor guesses 🙈😄. |
Fixes #34813
Notes
mainbranch, and I include the guidance on selecting the correct release branch/tag.❓Questions❓
ReconnectModelcomponent display in that scenario? There's no such class (element marked with) "components-reconnect-rejected-visible," and doesn'tcomponents-reconnect-failed-visiblego todisplay: noneon a rejection? I don't see any styles forcomponents-reconnect-rejectedwhen it's applied to the dialog.Internal previews