Skip to content

Conversation

@guardrex
Copy link
Collaborator

@guardrex guardrex commented Feb 27, 2025

Fixes #34813

Notes

  • I'm versioning all of the 10.0 or later content into one moniker range, and I'm disabling all of the existing content for <10.0. In the past, I broke up coverage into multiple moniker ranges because parts of the coverage changed (e.g., filenames, file locations).
  • I'm using our standard approach for cross-linking reference source. I link the main branch, and I include the guidance on selecting the correct release branch/tag.

❓Questions❓


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/fundamentals/signalr.md aspnetcore/blazor/fundamentals/signalr

@guardrex guardrex self-assigned this Feb 27, 2025
@guardrex guardrex requested a review from oroztocil February 28, 2025 10:36
@oroztocil
Copy link
Member

Sorry for keeping you waiting for the review. I first want to investigate and fix https://github.com/dotnet/AspNetCore-ManualTests/issues/3489 because it might involve changing some things mentioned in the docs.

@guardrex
Copy link
Collaborator Author

Thanks @oroztocil ... I'll work on this now and ping you back on the next commit.

@guardrex
Copy link
Collaborator Author

guardrex commented Mar 10, 2025

@oroztocil ... I retained the table, collapsed some of duplicate coverage a bit for the event, but I also split out the extended explanations to paragraphs under the table. I moved the ReconnectModal coverage to the end and rephrased the lead-in remarks to it. It's ready for another 👁️.

@guardrex
Copy link
Collaborator Author

... and @oroztocil ... see my questions in my OP ☝️. The first question is important on retaining the current images. The second question might not be something that we need in the coverage ... it could just be something simple that I don't understand.

@oroztocil
Copy link
Member

oroztocil commented Mar 10, 2025

@guardrex To answer your questions:

  • Yes, the images should still be accurate. The component reuses styles from the previous default solution.
  • On the rejected state event, the component calls location.reload which means the browser reloads the page. After the reload, the application is either displayed normally (if it reconnects to the Blazor server successfully), or the reconnection UI shows up again and goes through the various states again from start.
  • None come to mind at the moment. But I'll reach out to you if we find some based on user feedback.

@guardrex
Copy link
Collaborator Author

On the rejected state event, the component calls location.reload which means the browser reloads the page. After the reload, the application is either displayed normally (if it reconnects to the Blazor server successfully), or the reconnection UI shows up again and goes through the various states again from start.

I see ... yeah ... I think that's logical from reading the code. You can let me know if you think we should have remark about it at the end of the section.

@guardrex
Copy link
Collaborator Author

guardrex commented Mar 10, 2025

@oroztocil ... Is this getting better or WORSE? 😆

It looks like we should show example code for wiring up the event, so I added a simplified example.

Also, note that I did state the default for the .NET CLI ...

--interactivity server (default)

... but not for VS because IIRC 🤔 VS remembers the last app setup ... so Server/Auto isn't really a "default" for VS IIRC. Let me know if I'm wrong about that.

Copy link
Member

@oroztocil oroztocil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good now 🙂 I'd say this piece of functionality is inherently a bit difficult to document. (And I guess I should have written some summary of how the entire thing works to make it less confusing from the start.)

@guardrex
Copy link
Collaborator Author

No worries ... that's ok. It perhaps saved a little of your time for me to take a stab at it and just fix my poor guesses 🙈😄.

@guardrex guardrex merged commit 30f8f59 into main Mar 10, 2025
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-bwa-reconnection-ui branch March 10, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New reconnect UI component in the BWA template

3 participants