SSE return types /2 #35152
Merged
SSE return types /2 #35152
+175
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rick-Anderson
commented
Apr 8, 2025
Comment on lines
+1
to
+6
| using Microsoft.AspNetCore.Mvc; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Net.ServerSentEvents; | ||
|
|
||
| [ApiController] | ||
| [Route("[controller]")] |
Contributor
Author
There was a problem hiding this comment.
@mikekistler should I remove the controller sample? If not, where should I surface it?
Rick-Anderson
commented
Apr 8, 2025
| public record HeartRateRecord(DateTime Timestamp, int HeartRate) | ||
| { | ||
| public static HeartRateRecord Create(int heartRate) => new(DateTime.UtcNow, heartRate); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I changed the name from HearRate to HeartRateRecord
see original https://github.com/captainsafia/minapi-sse/blob/main/Program.cs#L60-L63
mikekistler
requested changes
Apr 9, 2025
Contributor
mikekistler
left a comment
mikekistler
left a comment
There was a problem hiding this comment.
This looks good but I think a few changes will make it great!
Co-authored-by: Mike Kistler <[email protected]>
Co-authored-by: Mike Kistler <[email protected]>
mikekistler
approved these changes
Apr 10, 2025
Contributor
mikekistler
left a comment
mikekistler
left a comment
There was a problem hiding this comment.
Looks good! 👍
I left a couple minor comments but fine to let you decide whether/how to resolve them.
aspnetcore/web-api/action-return-types/samples/10/ControllerSSE/HearRate.cs
Outdated
Show resolved
Hide resolved
Comment on lines
153
to
154
| #### Problem | ||
|
|
Contributor
There was a problem hiding this comment.
Were you planning to put something here?
…E/HearRate.cs Co-authored-by: Mike Kistler <[email protected]>
wadepickett
added a commit
that referenced
this pull request
Apr 10, 2025
* Adds .NET 9 sample to mongo app (#35189) * copy-paste to 9.x * update code to .NET 9 * update references to code * update references to 8.x code * upate ms date * add missing snapshot * Update aspnetcore/tutorials/first-mongo-app.md --------- Co-authored-by: Wade Pickett <[email protected]> * SSE return types /2 (#35152) * SSE return types /2 * SSE return types /2 * SSE return types /2 * SSE return types /2 * SSE return types /2 * fixes * Update aspnetcore/fundamentals/minimal-apis/responses.md Co-authored-by: Mike Kistler <[email protected]> * Apply suggestions from code review Co-authored-by: Mike Kistler <[email protected]> * react to feedback * Update aspnetcore/web-api/action-return-types/samples/10/ControllerSSE/HearRate.cs Co-authored-by: Mike Kistler <[email protected]> * react to feedback --------- Co-authored-by: Mike Kistler <[email protected]> * Update complex-data-model.md Fixes #35191 * WN .NET 10 Prev 3: Validation Support Minimal API (#35188) * WN .NET 10 Prev 3: Validation Support Minimal API * Added include to What's New topic for .NET 10 Preview 3 * Update with correct links * Format link for attribute * Correct DataAnnotations link * Add review suggestions, remove future tense and lines * Minor edit * Remove line breaks * fixed line break * [Pre3] Boot config file name change (#35176) * [Pre3] Declaratively persist state (#35198) * Blazor Pre3 final updates for release (#35200) * Patch Blazor Pre3 API (#35201) --------- Co-authored-by: Tim Deschryver <[email protected]> Co-authored-by: Wade Pickett <[email protected]> Co-authored-by: Rick Anderson <[email protected]> Co-authored-by: Mike Kistler <[email protected]> Co-authored-by: Luke Latham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35089
Support for Server-Sent Events (SSE)
Responses: Server-Sent Events (SSE)
Internal previews