Skip to content

Conversation

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Apr 24, 2025

contributes to #34880
replaces #35300

@CarnaViire please review

Public review of the doc build:

  • download the HTML files
  • unzip
  • view HTML file in a browser.
  • For links outside the doc, remove the review. from URL.

Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/servers/kestrel/http3.md aspnetcore/fundamentals/servers/kestrel/http3

@Rick-Anderson Rick-Anderson marked this pull request as draft April 24, 2025 18:00
@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Apr 24, 2025

@CarnaViire this PR creates a .NET 8 version and a .NET 9+ version. They're identical now so when I merge this and create another PR you'll see all the differences between the versions. This PR retains the .NET 8 version.

[!INCLUDE[](~/includes/not-latest-version.md)]

:::moniker range=">= aspnetcore-8.0"
:::moniker range="> aspnetcore-8.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V9 and higher


:::moniker-end

[!INCLUDE[](~/fundamentals/servers/kestrel/includes/http3-8.md)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include the V8 version

@@ -0,0 +1,69 @@
:::moniker range="= aspnetcore-8.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is the V8 version, a copy of aspnetcore/fundamentals/servers/kestrel/http3.md

@Rick-Anderson Rick-Anderson requested a review from ManickaP April 24, 2025 20:48
@Rick-Anderson Rick-Anderson marked this pull request as ready for review April 24, 2025 21:59
@CarnaViire
Copy link
Member

@Rick-Anderson the final version of this PR doesn't add any new files and only updates http3.md. Am I missing something, or can we actually go back and combine this into #35300?

@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Apr 25, 2025

@Rick-Anderson the final version of this PR doesn't add any new files and only updates http3.md. Am I missing something, or can we actually go back and combine this into #35300?

Per #35300 (comment), no new versioned file was needed. Sorry I hijacked your last PR. The HTTP/3 benefits section was so hard to read I couldn't resist having CoPilot rewrite it. Is this version an improvement or worse?

I have this as contributes to #34880, so #34880 won't be close. Can you do a follow up PR with what I missed?

Is this ready to merge?

Were you able to review the build?

Public review of the doc build:

  • download the HTML files
  • unzip
  • view HTML file in a browser.
  • For links outside the doc, remove the review. from URL.

@Rick-Anderson
Copy link
Contributor Author

@CarnaViire is there anything from 14b4b40 I should copy/paste?

@Rick-Anderson Rick-Anderson changed the title Rick/http/3/kestrel Rick/http/3/kestrel/zzz Apr 25, 2025
@guardrex guardrex deleted the rick/http/3/kestrel branch July 9, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants