-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Rick/http/3/kestrel/zzz #35302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rick/http/3/kestrel/zzz #35302
Conversation
|
@CarnaViire this PR creates a .NET 8 version and a .NET 9+ version. They're identical now so when I merge this and create another PR you'll see all the differences between the versions. This PR retains the .NET 8 version. |
| [!INCLUDE[](~/includes/not-latest-version.md)] | ||
|
|
||
| :::moniker range=">= aspnetcore-8.0" | ||
| :::moniker range="> aspnetcore-8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V9 and higher
|
|
||
| :::moniker-end | ||
|
|
||
| [!INCLUDE[](~/fundamentals/servers/kestrel/includes/http3-8.md)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include the V8 version
| @@ -0,0 +1,69 @@ | |||
| :::moniker range="= aspnetcore-8.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the V8 version, a copy of aspnetcore/fundamentals/servers/kestrel/http3.md
|
@Rick-Anderson the final version of this PR doesn't add any new files and only updates |
Per #35300 (comment), no new versioned file was needed. Sorry I hijacked your last PR. The HTTP/3 benefits section was so hard to read I couldn't resist having CoPilot rewrite it. Is this version an improvement or worse? I have this as contributes to #34880, so #34880 won't be close. Can you do a follow up PR with what I missed? Is this ready to merge? Were you able to review the build? Public review of the doc build:
|
|
@CarnaViire is there anything from 14b4b40 I should copy/paste? |
contributes to #34880
replaces #35300
@CarnaViire please review
Public review of the doc build:
review.from URL.Internal previews