-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Add copilot-instructions to repo #35812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
813cb17
Add copilot-instructions to repo
wadepickett 5e6a926
improved auth example question
wadepickett 89ce497
Added rule for ms.date format
wadepickett 00fc198
Update copilot-instructions.md
wadepickett 8d60470
Update copilot-instructions.md
wadepickett 23314f7
Update copilot-instructions.md
wadepickett ebe7aff
Update copilot-instructions.md
wadepickett d2f1046
Update copilot-instructions.md
wadepickett 9cdbe3b
Update copilot-instructions.md
wadepickett df5d6be
Update copilot-instructions.md
wadepickett a2b1c1a
Update .github/copilot-instructions.md
wadepickett f000dea
Update .github/copilot-instructions.md
wadepickett e948bab
Update copilot-instructions.md
wadepickett 3157f4d
Ensure ms.date format and upate
wadepickett 270764d
Fixed typo
wadepickett 7ad64c9
Added blank line for formatting
wadepickett 6d5fba2
Update copilot-instructions.md
wadepickett 873bf06
Update copilot-instructions.md
wadepickett da48207
Update copilot-instructions.md
wadepickett 6d195a1
Apply suggestions from code review
wadepickett bbd4801
Update .github/copilot-instructions.md
wadepickett 4d685d7
Apply suggestions from code review
wadepickett 658b8ac
Apply suggestions from code review
wadepickett 2f63cfa
Update .github/copilot-instructions.md
wadepickett 089f5b7
Update .github/copilot-instructions.md
wadepickett 812fc78
More suggestion added and clean up.
wadepickett 74f1650
Formatting and organziational fixes
wadepickett 06fa80a
Added guardrex code snippet suggestions
wadepickett d9d187b
Update .github/copilot-instructions.md
wadepickett d378c11
Update .github/copilot-instructions.md
wadepickett e16c857
Apply suggestions from code review
wadepickett 2ac229c
Updates per tdykstra suggestions
wadepickett ca17b39
Fixed pre-view instruction per tdykstra suggestion
wadepickett 999a274
update for API ref verify per tdykstra suggestion
wadepickett f9a8aa6
Added issue overview instructions per tdykstra suggestion
wadepickett 171777f
One last check for grammar
wadepickett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| --- | ||
| author: wadepickett | ||
| ms.author: wpickett | ||
| ms.date: 07-28-2025 | ||
| --- | ||
wadepickett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Copilot Instructions for `dotnet/AspNetCore.Docs` | ||
|
|
||
| ## Introduction | ||
|
|
||
| This document contains repository-specific instructions for GitHub Copilot when assisting with the `dotnet/AspNetCore.Docs` repository. **Unless otherwise specified, all ".NET" references refer to modern .NET, not .NET Framework.** | ||
|
|
||
| ## Repository-Specific Guidelines | ||
|
|
||
| - Follow the [Microsoft Writing Style Guide](https://learn.microsoft.com/en-us/style-guide/welcome/) | ||
wadepickett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - **Repository Exceptions**: | ||
| - Number ordered lists as "1." for every item (don't use sequential numbers) | ||
| - Use `code style` specifically for file names, folders, custom types, and code that should never be localized | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - For any new .md file added to the repository or any updated .md file ensure the standaerd frontmatter (meta data) specified by the Style Guide is included. | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - For any new .md file added to the repository or any updated .md file ensure the following frontmatter (meta data) is included. | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Metadata `ai-usage: ai-assisted` if any AI assistance was used | ||
| - Metadata `ms.date: <today's date>` with a format of DD-MM-YYYY. If the file already has a `ms.date` metadata, update it to today's date if more than 50 characters have changed in the file. | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Version Targeting | ||
|
|
||
| ### Detection Priority Order | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 1. **Explicit PR/Issue Instructions** - Prioritize explicit version ranges mentioned | ||
| 2. **File Metadata** - Check YAML frontmatter for specifications | ||
| 3. **Inline Moniker Tags** - Look for version range specifications | ||
| 4. **Repository Branch Context** - Consider branch where PR will be merged | ||
| 5. **Directory Structure** - Check for version-specific directories | ||
|
|
||
| ### Common Range Patterns | ||
| - Fixed Range: `>= aspnetcore-7.0 <= aspnetcore-9.0` | ||
| - Open Upper Bound: `>= aspnetcore-7.0` | ||
| - Open Lower Bound: `<= aspnetcore-9.0` | ||
| - Specific Version: `== aspnetcore-9.0` | ||
|
|
||
| ## API References and Verification | ||
|
|
||
| - Never guess API documentation IDs, always verify. If unable to verfy, say so. | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Check if features were introduced after .NET Core 3.1 | ||
| - Default to most compatible syntax when uncertain | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - For breaking changes, check: | ||
| - Changes to default behavior of existing APIs | ||
| - Removed or renamed public API elements | ||
| - Modified method signatures or return types | ||
| - Changed serialization formats | ||
| - Altered dependency requirements | ||
| - Changes to configuration schema | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Links and References | ||
|
|
||
| - Use **relative links** for files within this repo | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - For learn.microsoft.com links, **remove** `https://learn.microsoft.com/en-us` from URLs | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Use cross-references for APIs: `<xref:api-doc-ID>` | ||
|
||
| - Get doc ID from the relevant XML doc in dotnet-api-docs | ||
| - Omit first two characters of the doc ID | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Markdown File Naming and Organization | ||
|
|
||
| - If you're adding a new Markdown file, it should be named in all lowercase with hyphens separating words. Also, omit any filler words such as "the" or "a" from the file name. | ||
|
|
||
| ## Code Snippets | ||
|
|
||
| - For snippets **longer than 6 lines**: | ||
| - Place in separate `.cs` file in a `snippets` folder next to the Markdown file | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Create a subfolder named after the document | ||
| - For version-specific code, include a version folder | ||
| - Add a simple `.csproj` file targeting the appropriate .NET version | ||
|
|
||
| - Reference snippets using triple-colon syntax: | ||
| - **Use file-relative paths** for snippets specific to a single doc file: | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ``` | ||
| :::code language="csharp" source="../snippets/my-doc/Program.cs"::: | ||
| ``` | ||
| - **Use repository root-relative paths** for shared snippets: | ||
| ``` | ||
| :::code language="csharp" source="~/tutorials/min-web-api/samples/9.x/todoGroup/TodoDb.cs"::: | ||
| ``` | ||
| - For longer snippets, highlight specific lines: | ||
| ``` | ||
| :::code language="csharp" source="~/path/to/file.cs" range="5-10" highlight="2-3"::: | ||
| ``` | ||
| - Use modern C# coding patterns in all examples | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## ASP.NET Core Specific Guidelines | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - Use the latest supported version for examples unless otherwise specified | ||
wadepickett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Lead with Microsoft recommended approaches | ||
| - Include differences between minimal API and controller-based approaches when relevant | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - For middleware, lead with the middleware class approach | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - For Blazor, clearly distinguish between Server and WebAssembly hosting models | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Issue Handling | ||
|
|
||
| When creating a PR for an issue: | ||
| 1. Read the full issue and all linked references | ||
| 2. Study code samples from linked PRs for pre-release features | ||
| 3. For labeled issues: | ||
| - **breaking-change:** For general .NET breaking changes, reference [Breaking changes in .NET](../dotnet/core/compatibility/breaking-changes). For ASP.NET Core-specific breaking changes, add details to the "What's new" release notes file for the corresponding .NET version in this repo (using includes if appropriate), and cross-link to the main .NET breaking changes page. If no content is needed for a given release, ensure the release notes still link to the main breaking changes resource. | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - **new-feature:** State which version introduced the feature | ||
| - **bug:** Focus on correcting technical inaccuracies | ||
| 4. When you're assigned an issue, after you've completed your work and the workflows (status checks) have run, check to make sure there are no build warnings under the OpenPublishing.Build status check. If there are, open the build report (under View Details) and resolve any build warnings you introduced. | ||
wadepickett marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.