Skip to content

Conversation

@Dickson-Mwendia
Copy link
Contributor

@Dickson-Mwendia Dickson-Mwendia commented Jul 29, 2025


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
aspnetcore/blazor/components/data-binding.md ASP.NET Core Blazor data binding
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md Call .NET methods from JavaScript functions in ASP.NET Core Blazor
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md Call JavaScript functions from .NET methods in ASP.NET Core Blazor
aspnetcore/blazor/security/blazor-web-app-with-entra.md Secure an ASP.NET Core Blazor Web App with Microsoft Entra ID
aspnetcore/blazor/security/webassembly/index.md aspnetcore/blazor/security/webassembly/index
aspnetcore/blazor/security/webassembly/standalone-with-microsoft-accounts.md Secure an ASP.NET Core Blazor WebAssembly standalone app with Microsoft Accounts
aspnetcore/blazor/security/webassembly/standalone-with-microsoft-entra-id.md Secure an ASP.NET Core Blazor WebAssembly standalone app with Microsoft Entra ID
aspnetcore/data/ef-mvc/complex-data-model.md Tutorial: Create a complex data model - ASP.NET MVC with EF Core
aspnetcore/fundamentals/url-rewriting.md aspnetcore/fundamentals/url-rewriting
aspnetcore/host-and-deploy/iis/advanced.md Advanced configuration of the ASP.NET Core Module and IIS
aspnetcore/host-and-deploy/iis/index.md Host ASP.NET Core on Windows with IIS
aspnetcore/host-and-deploy/iis/web-config.md web.config file
aspnetcore/host-and-deploy/linux-nginx.md Host ASP.NET Core on Linux with Nginx
aspnetcore/migration/31-to-50.md [Visual Studio](https://review.learn.microsoft.com/en-us/aspnet/core/migration/31-to-50?branch=pr-en-us-35850)
aspnetcore/migration/31-to-60.md [Visual Studio Code](https://review.learn.microsoft.com/en-us/aspnet/core/migration/31-to-60?branch=pr-en-us-35850)
aspnetcore/mvc/views/tag-helpers/intro.md aspnetcore/mvc/views/tag-helpers/intro
aspnetcore/performance/caching/hybrid.md HybridCache library in ASP.NET Core
aspnetcore/security/app-secrets.md Safe storage of app secrets in development in ASP.NET Core
aspnetcore/security/authentication/2fa.md Two-factor authentication with SMS in ASP.NET Core
aspnetcore/security/authentication/accconfirm.md Account confirmation and password recovery in ASP.NET Core
aspnetcore/security/authentication/social/facebook-logins.md aspnetcore/security/authentication/social/facebook-logins
aspnetcore/security/authentication/social/index.md External provider authentication in ASP.NET Core Identity
aspnetcore/security/authentication/ws-federation.md Authenticate users with WS-Federation in ASP.NET Core
aspnetcore/security/authorization/secure-data.md Create an ASP.NET Core web app with user data protected by authorization
aspnetcore/security/docker-compose-https.md aspnetcore/security/docker-compose-https
aspnetcore/security/docker-https.md Hosting ASP.NET Core images with Docker over HTTPS
aspnetcore/security/index.md ASP.NET Core security topics
aspnetcore/tutorials/first-mongo-app.md Create a web API with ASP.NET Core and MongoDB
aspnetcore/tutorials/first-mvc-app/adding-model.md [Visual Studio](https://review.learn.microsoft.com/en-us/aspnet/core/tutorials/first-mvc-app/adding-model?branch=pr-en-us-35850)
aspnetcore/tutorials/publish-to-azure-webapp-using-vs.md aspnetcore/tutorials/publish-to-azure-webapp-using-vs

Note

This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Dickson-Mwendia ... Please don't change the order of the metadata. Make the changes only to the value when ms.custom is present. If the entry isn't present, it goes after ms.author (they're alphabetical after the title). Thx!

@Dickson-Mwendia
Copy link
Contributor Author

Dickson-Mwendia commented Jul 29, 2025

No worries, I used a script to pull these values from the security dashboard and insert them into the metadata blocks; but I can address this. Thanks @guardrex

@guardrex
Copy link
Collaborator

Also, why break out on separate lines when a comma-separated list will suffice and reduces scrolling?

@Dickson-Mwendia
Copy link
Contributor Author

Also, why break out on separate lines when a comma-separated list will suffice and reduces scrolling?

This is more of a lack of consistency in how we handle metadata across Microsoft docs repos. We're running the script across 200+ repos, and somehow there's no single way on how it's done. We had to standardize how we insert the values to avoid busted entries in some cases.

@guardrex
Copy link
Collaborator

somehow there's no single way on how it's done

I can explain that ...... but I'm not going to. 😆

I defer to @tdykstra and @wadepickett on if we should run our own script after this merges to collapse them back to one line.

@wadepickett wadepickett self-requested a review July 30, 2025 16:53
@wadepickett
Copy link
Contributor

Closing and re-opening to force a new content build since some Identity related API Ref that was missing from another team was just fixed, which should take care of the cross-reference warnings...

@wadepickett
Copy link
Contributor

Closing and re-opeining to force a new content build since some Identity related API Ref that was missing from another team was just fixed.

@wadepickett wadepickett reopened this Jul 30, 2025
@wadepickett
Copy link
Contributor

wadepickett commented Jul 30, 2025

@Dickson-Mwendia and @guardrex, closing and reopening the build took care of all the cross-link API Reference warnings, but there is a merge conflict error:

[Error] Cannot merge commit a60e7a7 in branch dmwendia-sfi-mscustom of repository https://github.com/Dickson-Mwendia/AspNetCore.Docs into branch main (commit f275bd5). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

@guardrex, it looks like a merge conflict on a blazor doc. I defer to you, since you will recognize right away what stays in.

@wadepickett
Copy link
Contributor

somehow there's no single way on how it's done

I can explain that ...... but I'm not going to. 😆

I defer to @tdykstra and @wadepickett on if we should run our own script after this merges to collapse them back to one line.

Unless we find it breaks something later, I think we should leave the ms.custom in the format used throughout the org so that as they need to be updated later it isn't a pain for the SFI team.

@guardrex
Copy link
Collaborator

I'll see about resolving the conflicts. Give me few minutes ... I'm just wrapping up something.

the format used throughout the org ... so that as they need to be updated later it isn't a pain for the SFI team.

Of course, whatever MS decides is fine with me, but I observe that ...

  • They don't need to modify the metadata very often, but we need need to scroll it many times every day. It isn't cost effective to introduce more scrolling than is required 💰.
  • They can easily script for single-line changes. It's simple.

@dotnet-policy-service dotnet-policy-service bot requested a review from guardrex July 30, 2025 17:50
@guardrex
Copy link
Collaborator

Merge commits are resolved.

WRT the metadata ordering, we had a convention to follow that worked well ... it's kind'a gone to heck in a handbasket over the years in the main doc set, but I still consistently use it across the Blazor node to keep Blazor article management cost effective 💰 for Microsoft. I'll discuss the situation with DR offline.

@wadepickett
Copy link
Contributor

"They can easily script for single-line changes. It's simple."
Yes, that is obvious. Having to deal with making exceptions at scale for so many repos does cost some time, however. If it is not a huge problem, being able to run it the same way for all repositories is nice to have.

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Dickson-Mwendia! Thanks @guardrex for the quick merge conflict fix!

@guardrex
Copy link
Collaborator

I'll remove myself from review to let MS do this 💸.

@guardrex guardrex removed their request for review July 30, 2025 18:26
@wadepickett
Copy link
Contributor

@guardrex, if you still think this PR needs a change, we can work that out. I didn't mean for my own approval to rule that out.

@wadepickett wadepickett self-requested a review July 30, 2025 18:43
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly thought that addressing the alpha order of the metadata had already happened.
@Dickson-Mwendia were you going to fix that? It is a guideline we have as an org, but we also want to be wary that you are dealing with 200+ repos and trying to get this done. There is also a July deadline, and it is 7/30, so I am keeping that in awareness as well since this is a very last minute concern.

cc @guardrex

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum 🤔 ... GH doesn't permit dropping the change request by removing the review request. I'll try to "Comment" to remove it.

@guardrex guardrex dismissed their stale review July 30, 2025 18:49

Ah! ... I forgot the "dismiss review" process.

@wadepickett
Copy link
Contributor

The deadline for this is tomorrow. If we have to we can fix after this PR, understanding that @Dickson-Mwendia is trying to herd 200+ repos to completion by that time. @Dickson-Mwendia if you can fix for this PR today, great. If it is problematic given the scale of what you are trying to pull over the finish line by tomorrow, we can certainly consider that.

@Dickson-Mwendia
Copy link
Contributor Author

@wadepickett @guardrex thank you so much for the review and feedback here. I'll come back and fix the metadata order tomorrow (7/31). Let's hold off merging for today. I'll ping you both for sign-off once done.

@dotnet-policy-service dotnet-policy-service bot requested a review from guardrex July 31, 2025 13:35
@Dickson-Mwendia
Copy link
Contributor Author

Dickson-Mwendia commented Jul 31, 2025

@wadepickett @guardrex I've addressed the issues discussed and this is now ready for review.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Dickson-Mwendia, for doing that. There's just two spots to flip the author from Rick back to Tom. Other than that, LGTM! 🎉

@dotnet-policy-service dotnet-policy-service bot requested a review from guardrex July 31, 2025 13:51
@Dickson-Mwendia
Copy link
Contributor Author

There's just two spots to flip the author from Rick back to Tom.

Perfect, this is now addressed, @guardrex

@guardrex guardrex requested a review from wadepickett July 31, 2025 13:52
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @Dickson-Mwendia and @guardrex!

@wadepickett
Copy link
Contributor

@tdykstra and @guardrex,

We still have xref issues for what I think is missing API from the Preview 5 & 6 API ref build that was on hold because it had a mess of errors.

Should we squash and merge this anyway?

xref-not-found aspnetcore/mvc/models/file-uploads.md Cross reference not found: 'Microsoft.Azure.Storage.File.CloudFile.UploadFromFileAsync*'.
xref-not-found aspnetcore/mvc/models/file-uploads.md Cross reference not found: 'Microsoft.Azure.Storage.File.CloudFile.UploadFromStreamAsync*'.

@guardrex
Copy link
Collaborator

Yes, those are the ✨ NEW ✨ MIA API entries. They exist, so it's another XREF/build problem.

@wadepickett wadepickett merged commit 6a51096 into dotnet:main Jul 31, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants