-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Update dates to rebuild articles #35858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@guardrex, I am seeing the same issue in the live docs with the raw xref in there. That would seem to be due to the identity API Ref missing which wasn't fixed until this morning. It didn't occur to me that it would do that as a result of not finding the API ref, but that makes sense. |
|
What about the review article tho? The live doc is definitely going to be broken until this merges to live. |
|
The review article is ok? |
|
Typing while you are typing.... |
|
You can tell that by looking at the review article section at ... Second bullet point ... if it's XREF, then I'll rebuild this. If it's links, then 🎉 ... good to go. |
|
I would close, reopen and get a new build to see if it resolves now if you haven't done that in the last few hours. They said the identity fix would need some time to show up even though it was merged. |
|
You might also clear cache on your browser end for good luck. |
|
I can't see the review articles ... no credentials. That's why I asked for you or Tom to look and tell me. |
|
Ok ... try now ... If it's still XREFs, then yeah ... this will need to wait a bit longer. I guess we'll try again tomorrow. |
|
I think maybe you missed where I replied and said I was seeing the problem. Just a sec... |
|
I am not seeing xref now. For example: looks good. |
🎉 Booyeah! 💃🕺Merging now! |
|
I did forget that you can't see the internal build. Sorry. |
|
Thanks @wadepickett for your help getting this whole problem over the finish line. We're back in bizness! |
|
This makes me worried however that we have stuff we need to republish from the last few days that linked to Identity that went live. I will go check a few. It was not an issue in all docs but there were a few that used those links. |
|
I think I changed all of the dates of all of the articles that were having problems. I think we're ok. |
Fixes #35857
For one article with today's date, I collapsed the 'not current' INCLUDE by a line. For another one, I found a double-space to fix.
Wade or Tom, could you pop open the Call web API review article to confirm that the build engine placed actual links, not XREFs, into the content?
An example from the live doc set is in this section (second bullet in the list) ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?view=aspnetcore-9.0#microsoft-identity-platform-for-web-api-calls
This is the review link that goes right there to confirm that those are real links now ...
https://review.learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?branch=pr-en-us-35858#microsoft-identity-platform-for-web-api-calls
Internal previews