Skip to content

Conversation

@guardrex
Copy link
Collaborator

@guardrex guardrex commented Jul 29, 2025

Fixes #35857

For one article with today's date, I collapsed the 'not current' INCLUDE by a line. For another one, I found a double-space to fix.

Wade or Tom, could you pop open the Call web API review article to confirm that the build engine placed actual links, not XREFs, into the content?

An example from the live doc set is in this section (second bullet in the list) ...

https://learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?view=aspnetcore-9.0#microsoft-identity-platform-for-web-api-calls

image

This is the review link that goes right there to confirm that those are real links now ...

https://review.learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?branch=pr-en-us-35858#microsoft-identity-platform-for-web-api-calls


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/call-web-api.md aspnetcore/blazor/call-web-api
aspnetcore/blazor/security/blazor-web-app-with-entra.md aspnetcore/blazor/security/blazor-web-app-with-entra
aspnetcore/blazor/security/blazor-web-app-with-oidc.md aspnetcore/blazor/security/blazor-web-app-with-oidc
aspnetcore/blazor/security/webassembly/hosted-with-azure-active-directory-b2c.md aspnetcore/blazor/security/webassembly/hosted-with-azure-active-directory-b2c
aspnetcore/blazor/security/webassembly/hosted-with-microsoft-entra-id.md aspnetcore/blazor/security/webassembly/hosted-with-microsoft-entra-id
aspnetcore/blazor/security/webassembly/microsoft-entra-id-groups-and-roles-net-5-to-7.md aspnetcore/blazor/security/webassembly/microsoft-entra-id-groups-and-roles-net-5-to-7
aspnetcore/release-notes/aspnetcore-5.0.md aspnetcore/release-notes/aspnetcore-5.0

@guardrex guardrex self-assigned this Jul 29, 2025
@guardrex guardrex requested review from tdykstra and wadepickett July 29, 2025 17:03
@wadepickett
Copy link
Contributor

@guardrex, I am seeing the same issue in the live docs with the raw xref in there. That would seem to be due to the identity API Ref missing which wasn't fixed until this morning. It didn't occur to me that it would do that as a result of not finding the API ref, but that makes sense.

@guardrex
Copy link
Collaborator Author

guardrex commented Jul 29, 2025

What about the review article tho? The live doc is definitely going to be broken until this merges to live.

https://review.learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?branch=pr-en-us-35858#microsoft-identity-platform-for-web-api-calls

@guardrex
Copy link
Collaborator Author

The review article is ok?

@wadepickett
Copy link
Contributor

Typing while you are typing....
Yes, I wouldn't publish it until you get a build with the xrefs resolving correctly so they are not dropping in as raw xref.

@guardrex
Copy link
Collaborator Author

You can tell that by looking at the review article section at ...

https://review.learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?branch=pr-en-us-35858#microsoft-identity-platform-for-web-api-calls

Second bullet point ... if it's XREF, then I'll rebuild this. If it's links, then 🎉 ... good to go.

@wadepickett
Copy link
Contributor

I would close, reopen and get a new build to see if it resolves now if you haven't done that in the last few hours. They said the identity fix would need some time to show up even though it was merged.

@guardrex guardrex closed this Jul 29, 2025
@guardrex guardrex reopened this Jul 29, 2025
@wadepickett
Copy link
Contributor

You might also clear cache on your browser end for good luck.

@guardrex
Copy link
Collaborator Author

I can't see the review articles ... no credentials. That's why I asked for you or Tom to look and tell me.

@guardrex
Copy link
Collaborator Author

Ok ... try now ...

https://review.learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?branch=pr-en-us-35858#microsoft-identity-platform-for-web-api-calls

If it's still XREFs, then yeah ... this will need to wait a bit longer. I guess we'll try again tomorrow.

@wadepickett
Copy link
Contributor

I think maybe you missed where I replied and said I was seeing the problem.

Just a sec...

@wadepickett
Copy link
Contributor

I am not seeing xref now.

For example:
EnableTokenAcquisitionToCallDownstreamApi: Enables token acquisition to call web APIs.

looks good.

@guardrex
Copy link
Collaborator Author

🎉 Booyeah! 💃🕺

Merging now!

@wadepickett
Copy link
Contributor

I did forget that you can't see the internal build. Sorry.

@guardrex guardrex merged commit 13c3d66 into main Jul 29, 2025
4 checks passed
@guardrex guardrex deleted the guardrex/blazor-article-dates-for-api branch July 29, 2025 23:56
@guardrex
Copy link
Collaborator Author

Thanks @wadepickett for your help getting this whole problem over the finish line. We're back in bizness!

@wadepickett
Copy link
Contributor

This makes me worried however that we have stuff we need to republish from the last few days that linked to Identity that went live. I will go check a few. It was not an issue in all docs but there were a few that used those links.

@guardrex
Copy link
Collaborator Author

I think I changed all of the dates of all of the articles that were having problems. I think we're ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rebuild/publish to enable XREF links

3 participants