Skip to content

Conversation

@JaredMSFT
Copy link
Contributor

@JaredMSFT JaredMSFT commented Aug 5, 2025

@JaredMSFT JaredMSFT requested a review from tdykstra as a code owner August 5, 2025 14:30
@JaredMSFT
Copy link
Contributor Author

@dotnet-policy-service agree company="Microsoft"

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; I just noticed a couple mentions of passwords and they need something said about secure handling of credentials. See the article I linked to in the comments below.

@tdykstra tdykstra self-requested a review August 8, 2025 02:18
@wadepickett wadepickett self-requested a review August 8, 2025 02:40
@wadepickett
Copy link
Contributor

@tdykstra, adding myself as a backup reviewer per your request.

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaredMSFT, this looks great!!. I only see a very minor item to consider:
Should "Postgres" should be "PostgreSQL" to avoid using two different names for the same thing? If so I can change that for you and publish, otherwise I will publish as is.

Sql Server > SQL Server typo fix.
@JaredMSFT JaredMSFT closed this Aug 9, 2025
@JaredMSFT JaredMSFT reopened this Aug 9, 2025
@wadepickett wadepickett merged commit 936addf into dotnet:main Aug 9, 2025
4 checks passed

After installing the [Microsoft.Extensions.Caching.Postgres](https://www.nuget.org/packages/Microsoft.Extensions.Caching.Postgres) NuGet package, configure your distributed cache as follows:

1. Register the Service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For code blocks inside an ordered list Every line needs to be indented three characters-- if You don't do that the numbering isn't right See the screenshot of the published article where the numbers jump from 1 to 3

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants