Skip to content

Conversation

@mohaimenDev
Copy link
Contributor

@mohaimenDev mohaimenDev commented Sep 8, 2025

This change adds a section to the official documentation on how to view the GetDocument step logs using the .NET Terminal Logger.

Original PR: dotnet/aspnetcore#63251


Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/openapi/aspnetcore-openapi.md aspnetcore/fundamentals/openapi/aspnetcore-openapi

mohaimenpxl and others added 2 commits September 8, 2025 17:42
Updated the date and improved section headings for clarity.
@guardrex guardrex self-assigned this Sep 8, 2025
@guardrex
Copy link
Collaborator

guardrex commented Sep 8, 2025

Thanks, @mohaimenDev! If you agree with the terms, please sign the CLA ☝️ in order for us to accept this.

@mohaimenDev
Copy link
Contributor Author

@dotnet-policy-service agree

@guardrex
Copy link
Collaborator

guardrex commented Sep 9, 2025

Thanks @mohaimenDev! We'll get a review/approval from @captainsafia next.

Safia ... a few side-notes .......

  • The -tlp option (terminal logger provider) doesn't seem to be documented anywhere. If you know of a landing page that I can cross-link, I'm 👂 for it.
  • Although dotnet build docs use "terminal logger" as a common noun, it's actually a proper noun (Terminal Logger) IMO (as submitted by @mohaimenDev), so it really should be capitalized. Let's do that here. I've opened an issue on the dotnet build article asking Andy to consider it making it a proper noun there.
  • I think "GetDocument" in this context shouldn't be localized, so I'm preventing localization on the PR. Let me know if it should be translated (and probably with a space between "Get" and "Document"). 👂

... and sorry for all of the pings! 🙈 I think I finally have my act together here! 🤞🍀😄

Updated wording for clarity and consistency in OpenAPI documentation.
@guardrex

This comment was marked as outdated.

@guardrex guardrex changed the title Docs: Add instructions for viewing build-time OpenAPI logs with Termi… Add instructions for viewing build-time OpenAPI logs Sep 18, 2025
@guardrex

This comment was marked as outdated.

@guardrex
Copy link
Collaborator

@captainsafia ... In passing, I see some little NITs 😈 in the article. I'll open an issue to address them separately and ping u for review later.

@guardrex guardrex merged commit 7dfda7e into dotnet:main Sep 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants