-
Notifications
You must be signed in to change notification settings - Fork 25.1k
docs(OpenApi): Bump example to .NET 10 #36184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello @xC0dex ... Does this address an open issue? Per our guidelines, we require an issue for anything that isn't a minor patch change. To open an issue, use the Open a documentation issue link at the bottom of the article that pertains to this code. Then, this PR receives a "Fixes XXX" line in the OP, where "XXX" is the issue number. |
Hey @guardrex, thanks for the clarification. I didn’t consider that a minor change. The reason for the change is that the current documentation shows some invalid code, as some APIs will change with .NET 10. |
I'm explaining the policy on this repo for when we need an issue ...
|
@xC0dex ... We still need an issue for this PR. What article does this go with? ... I'll open an issue for this and then ping the right folks to look at this PR. |
Hey @guardrex, Sorry for the late reply! I’ll open an issue and include an explanation of why this change is needed. |
Thanks! add "Fixes {ISSUE NUMBER}" at the top of your OP on this PR and ping me back 👂. |
@guardrex, done! |
Cool, thx ... I'll ping Safia now to take a look at this. |
@captainsafia ... This is for changes to the sample app at https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/fundamentals/openapi/samples/10.x/WebMinOpenApi. I'm not sure if companion article changes are needed. If you're not sure either, let me know 👂... I'll take a look. |
This PR updates the
WebMinOpenApi
project to .NET 10.Fixes #36195
Please let me know if I should also update the remaining OpenAPI examples. 🙂