Skip to content

Conversation

xC0dex
Copy link
Contributor

@xC0dex xC0dex commented Oct 5, 2025

This PR updates the WebMinOpenApi project to .NET 10.

Fixes #36195

Please let me know if I should also update the remaining OpenAPI examples. 🙂

@xC0dex xC0dex marked this pull request as ready for review October 5, 2025 11:18
@guardrex
Copy link
Collaborator

guardrex commented Oct 6, 2025

Hello @xC0dex ... Does this address an open issue? Per our guidelines, we require an issue for anything that isn't a minor patch change. To open an issue, use the Open a documentation issue link at the bottom of the article that pertains to this code. Then, this PR receives a "Fixes XXX" line in the OP, where "XXX" is the issue number.

@xC0dex
Copy link
Contributor Author

xC0dex commented Oct 6, 2025

Hey @guardrex, thanks for the clarification. I didn’t consider that a minor change.

The reason for the change is that the current documentation shows some invalid code, as some APIs will change with .NET 10.

@guardrex
Copy link
Collaborator

guardrex commented Oct 6, 2025

I'm explaining the policy on this repo for when we need an issue ...

  • If the dev only makes a patch change, we don't need an issue first.
  • If the dev makes major changes (such as what's on this PR), then we need an issue. We recommend opening the issue first to dicsuss the changes before the PR is submitted. In this case, you already opened the PR, so you should open an issue now ... and then mark this with a "Fixes XXX" line in the OP. Use the link at the bottom of the article that this sample pertains to. Taking that approach will add our tracking metadata to the issue automatically.

@guardrex
Copy link
Collaborator

guardrex commented Oct 8, 2025

@xC0dex ... We still need an issue for this PR. What article does this go with? ... I'll open an issue for this and then ping the right folks to look at this PR.

@xC0dex
Copy link
Contributor Author

xC0dex commented Oct 8, 2025

Hey @guardrex,

Sorry for the late reply! I’ll open an issue and include an explanation of why this change is needed.

@guardrex
Copy link
Collaborator

guardrex commented Oct 8, 2025

Thanks! add "Fixes {ISSUE NUMBER}" at the top of your OP on this PR and ping me back 👂.

@xC0dex
Copy link
Contributor Author

xC0dex commented Oct 8, 2025

@guardrex, done!

@guardrex
Copy link
Collaborator

guardrex commented Oct 8, 2025

Cool, thx ... I'll ping Safia now to take a look at this.

@guardrex guardrex requested a review from captainsafia October 8, 2025 14:32
@guardrex
Copy link
Collaborator

guardrex commented Oct 8, 2025

@captainsafia ... This is for changes to the sample app at https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/fundamentals/openapi/samples/10.x/WebMinOpenApi.

I'm not sure if companion article changes are needed. If you're not sure either, let me know 👂... I'll take a look.

@guardrex guardrex self-assigned this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OpenAPI code examples to .NET 10
2 participants