Skip to content

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Oct 8, 2025

Fixes #36045

I use links to avoid us having to worry about the portal changing. The links go to ...

In the bullet for "{KEY IDENTIFIER}," the only change that I'm making there is a slight highlight (italics) of the word "versionless" because they need to be careful not to peg the key to a version with a GUID. The rest of that remains unchanged.

I add a paragraph on the key config, calling out key permissions and what to do if they plan to use automatic key rotation.


Internal previews

📄 File 🔗 Preview link
aspnetcore/security/data-protection/configuration/overview.md aspnetcore/security/data-protection/configuration/overview

@guardrex guardrex self-assigned this Oct 8, 2025
@guardrex guardrex requested a review from Copilot October 8, 2025 14:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive guidance for Azure Key Vault setup and key generation to the ASP.NET Core Data Protection configuration documentation. The changes address issue #36045 by providing users with direct links to Azure documentation and clear instructions for configuring key vault permissions and key rotation settings.

Key changes:

  • Added hyperlinks to Azure Key Vault creation and key generation quickstart guides
  • Included new paragraphs explaining key permissions and automatic rotation considerations
  • Enhanced NuGet package references with proper markdown formatting

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I could not find any issues. Approved.

@guardrex guardrex merged commit a71d134 into main Oct 9, 2025
3 checks passed
@guardrex guardrex deleted the guardrex/key-vault-guidance branch October 9, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UUF: Configure ASP.NET Core Data Protection: Clarify with a create key step
2 participants