Skip to content

Conversation

@wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Nov 14, 2025

Fixes #36356

Update the Not-latest.. includes to account for .NET 10 GA

@wadepickett wadepickett self-assigned this Nov 14, 2025
@wadepickett wadepickett marked this pull request as draft November 14, 2025 16:59
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, we should add 11 now.

@wadepickett
Copy link
Contributor Author

wadepickett commented Nov 14, 2025

@guardrex, do you know how to get around the catch for this situation. (See build errors) It seems early to list a v 11 in the selector list (I would think) , but I suspect referring to > 10.0 in moniker range may be the issue. Or maybe I am missing something else?

@wadepickett
Copy link
Contributor Author

@tdykstra & @guardrex. I think the solution here is to exclude > v10 until the the next preview version is closer. then we add that version to the not-latest-version includes and to the version selector

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version-related include files to reflect .NET 10 as the current GA release, replacing references to .NET 9. The changes prepare the documentation infrastructure for the .NET 10 release cycle by updating moniker ranges and temporarily commenting out the preview version section until .NET 11 preview is added.

Key Changes

  • Updated moniker ranges from aspnetcore-9.0 to aspnetcore-10.0 to designate .NET 10 as the current release
  • Commented out the preview version section (for .NET 11) until it's added to the version selector
  • Updated documentation comments to reflect version targeting guidance for .NET 10

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
aspnetcore/includes/not-latest-version.md Updated version references from .NET 9 to .NET 10, commented out preview section, and updated usage guidance
aspnetcore/includes/not-latest-version-without-not-supported-content.md Updated version references from .NET 9 to .NET 10, commented out preview section, and updated usage guidance; contains an unintended character on line 29

@wadepickett wadepickett marked this pull request as ready for review November 14, 2025 21:01
@wadepickett
Copy link
Contributor Author

wadepickett commented Nov 14, 2025

@tdykstra, made a change since you looked last. I excluded > v10 until we are ready to add a new forward looking preview version in the version selector.

Handy test link:
https://review.learn.microsoft.com/en-us/aspnet/core/blazor/advanced-scenarios?view=aspnetcore-10.0&branch=pr-en-us-36355

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wadepickett wadepickett merged commit 7a1593e into main Nov 14, 2025
4 checks passed
@wadepickett wadepickett deleted the wadepickett/RemovePreviewTopOfPageNote branch November 14, 2025 21:56
@guardrex
Copy link
Collaborator

Sorry @wadepickett that I wasn't able to respond last week. I ran out of hours ... and hit a 🧠🔥. It's that time of year again ... NO vacation for going on nine years will do that to you! 😆 BUT ... 🦃 Days and ⛄ holidays are just about here for me to recharge with the tiny bit of time off that I do get. Anyway, are you OK here with this? I wasn't planning on looking unless you need me to, as I'm still cranking away on the final 10.0 NITs and BITs this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Note-latest-version includes

4 participants