-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Not-latest includes updated for post .NET 10 #36355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, we should add 11 now.
|
@guardrex, do you know how to get around the catch for this situation. (See build errors) It seems early to list a v 11 in the selector list (I would think) , but I suspect referring to > 10.0 in moniker range may be the issue. Or maybe I am missing something else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the version-related include files to reflect .NET 10 as the current GA release, replacing references to .NET 9. The changes prepare the documentation infrastructure for the .NET 10 release cycle by updating moniker ranges and temporarily commenting out the preview version section until .NET 11 preview is added.
Key Changes
- Updated moniker ranges from
aspnetcore-9.0toaspnetcore-10.0to designate .NET 10 as the current release - Commented out the preview version section (for .NET 11) until it's added to the version selector
- Updated documentation comments to reflect version targeting guidance for .NET 10
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
aspnetcore/includes/not-latest-version.md |
Updated version references from .NET 9 to .NET 10, commented out preview section, and updated usage guidance |
aspnetcore/includes/not-latest-version-without-not-supported-content.md |
Updated version references from .NET 9 to .NET 10, commented out preview section, and updated usage guidance; contains an unintended character on line 29 |
aspnetcore/includes/not-latest-version-without-not-supported-content.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
|
@tdykstra, made a change since you looked last. I excluded > v10 until we are ready to add a new forward looking preview version in the version selector. Handy test link: |
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
Sorry @wadepickett that I wasn't able to respond last week. I ran out of hours ... and hit a 🧠🔥. It's that time of year again ... NO vacation for going on nine years will do that to you! 😆 BUT ... 🦃 Days and ⛄ holidays are just about here for me to recharge with the tiny bit of time off that I do get. Anyway, are you OK here with this? I wasn't planning on looking unless you need me to, as I'm still cranking away on the final 10.0 NITs and BITs this week. |
Fixes #36356
Update the Not-latest.. includes to account for .NET 10 GA