-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Further work on standalone WASM environments #36390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Co-authored-by: Copilot <[email protected]>
maraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding content on a few ways that a dev can control the value. These are common approaches for this sort of task, so I'm not testing them all. I'm 👂 if you have any concerns.
It looks good to me
I'm adding a bit on using a web API endpoint that the WASM app can hit. Should we show some startup JS code that would make that work? ... or is it best to just consider it an 'advanced scenario' for the dev to work out on their own?
I think it's fine leaving it as an advanced scenario module the comment below
Otherwise, it looks great! Thank you
Fixes #36371
Marek ...
Internal previews