update screenshots to match the description #36394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Add Safari compatibility note to localhost-tld.md Co-authored-by: wadepickett <[email protected]> * Apply suggestions from code review - clarified "client" app. * Update aspnetcore/test/localhost-tld.md Co-authored-by: Tom Dykstra <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: wadepickett <[email protected]> Co-authored-by: Wade Pickett <[email protected]> Co-authored-by: Tom Dykstra <[email protected]>
Contributor
Author
|
I messed up with git, I will close this PR and open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36359
Create a screenshot before the formatting data attributes are added (no format for display names, and date value formatting).
Create a screenshot after the formatting.
Update the existing screenshot with the final view (including the currency). AFAIK this screenshot isn't currently used.
Update the description to also mention that the formatting of the model works because the view uses the
@Html.DisplayFormethods. This is already code that's covered in previous chapters, but it doesn't explicitly mentions the use of these methods.Update the final screenshot of chapter 5, this should also not show the formatted fields.
Internal previews