-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Additional Blazor script coverage and fix comments #36415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,11 +70,11 @@ The `Components/Pages` folder of the server project contains the app's routable | |
| Add the angle brackets around the cross-link when | ||
| activating. | ||
|
|
||
| :::moniker range=">= aspnetcore-10.0" | ||
| moniker range=">= aspnetcore-10.0" | ||
|
|
||
| The `NotFound` component (`NotFound.razor`) implements a Not Found page to display when content isn't found for a request path. For more information, see xref:blazor/fundamentals/navigation#not-found-responses. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This text is not showing as intended when the version selector is set to .NET 10.0
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (ugh, I accidently deleted this thinking I had clicked to reply on your quote, sorry). Original comment ...
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "It's commented out on purpose." @guardrex, maybe we are we talking about the same text? It is the following text I am referring to below. It looks like it was intended to show in 10 but does not show in 10: "The
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, per Line 66 ... this bit (Line 75 inclusive) shouldn't appear at this time.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The commented-out text runs from Line 66 to Line 79. I'm just seeking to remove the triple-colons from this HTML comment block to try and resurface the MIA parts of the article 🤞🍀 ... if the server gods will bless the attempt 🙏😄.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the 7.0 version of the article, which is currently ... https://learn.microsoft.com/en-us/aspnet/core/blazor/project-structure?view=aspnetcore-7.0 ... gets its content back in the review 7.0 article (which I can't see), then these changes work ... it is the triple-colon syntax in HTML comments that breaks article rendering, which I think is what you saw on that not-latest-version INCLUDES file PR from a week or two ago. |
||
|
|
||
| :::moniker-end | ||
| moniker-end | ||
|
|
||
| --> | ||
|
|
||
|
|
@@ -332,19 +332,19 @@ Project structure: | |
| Add the angle brackets around the cross-link when | ||
| activating. | ||
|
|
||
| :::moniker-end | ||
| moniker-end | ||
|
|
||
| :::moniker range=">= aspnetcore-10.0" | ||
| moniker range=">= aspnetcore-10.0" | ||
|
|
||
| * `Pages` folder: Contains the Blazor app's routable Razor components (`.razor`). The route for each page is specified using the [`@page`](xref:mvc/views/razor#page) directive. The template includes the following components: | ||
| * `Counter` component (`Counter.razor`): Implements the Counter page. | ||
| * `Index` component (`Index.razor`): Implements the Home page. | ||
| * `Weather` component (`Weather.razor`): Implements the Weather page. | ||
| * `NotFound` component (`NotFound.razor`) Implements a Not Found page to display when content isn't found for a request path. For more information, see xref:blazor/fundamentals/navigation#not-found-responses. | ||
|
|
||
| :::moniker-end | ||
| moniker-end | ||
|
|
||
| :::moniker range=">= aspnetcore-8.0 < aspnetcore-10.0" | ||
| moniker range=">= aspnetcore-8.0 < aspnetcore-10.0" | ||
|
|
||
| --> | ||
|
|
||
|
|
@@ -357,9 +357,9 @@ Project structure: | |
| https://github.com/dotnet/AspNetCore.Docs/pull/36145 | ||
| is merged. | ||
|
|
||
| :::moniker-end | ||
| moniker-end | ||
|
|
||
| :::moniker range=">= aspnetcore-8.0" | ||
| moniker range=">= aspnetcore-8.0" | ||
|
|
||
| --> | ||
|
|
||
|
|
||

Uh oh!
There was an error while loading. Please reload this page.