-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Update HTTP request pipeline config remarks #36421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the HTTP request pipeline configuration documentation to correctly indicate that the described middleware runs when the app is NOT in the Development environment. The change corrects a heading from "In the development environment:" to "When the app isn't running in the Development environment:", which properly aligns with the code block showing if (!app.Environment.IsDevelopment()).
Key Changes:
- Updated documentation heading to correctly describe non-development environment middleware configuration
Co-authored-by: Copilot <[email protected]>
| Next, the HTTP request pipeline is configured. | ||
|
|
||
| In the development environment: | ||
| When the app isn't running in the Development environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit and I could see it either way, but seems like we might use code ticks around "Development" here if it is to be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been unable to stick to a convention on this one 😢. I'm going to make a tracking item entry to go through all of the Blazor docs and make it consistent. I'll go code style on the next commit; and with @tdykstra, you can let me know which convention you ultimately settle on. It sounds like for now that we'll code style the environment names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vote goes for code style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well ..... I've been about 50-50 on it one way or the other I'm sorry to say on this one 🙈😆.
Because this is a low priority item to address, I've made a tracking entry on it. I'll circle around later, open an issue, and knock it out.
Fixes #36418
Thanks @test-test-test14! 🚀
Internal previews