Skip to content

Conversation

@guardrex
Copy link
Collaborator

@guardrex guardrex commented Dec 2, 2025

Fixes #36418

Thanks @test-test-test14! 🚀


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/tutorials/movie-database-app/part-1.md aspnetcore/blazor/tutorials/movie-database-app/part-1

@guardrex guardrex requested a review from Copilot December 2, 2025 17:42
@guardrex guardrex self-assigned this Dec 2, 2025
Copilot finished reviewing on behalf of guardrex December 2, 2025 17:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the HTTP request pipeline configuration documentation to correctly indicate that the described middleware runs when the app is NOT in the Development environment. The change corrects a heading from "In the development environment:" to "When the app isn't running in the Development environment:", which properly aligns with the code block showing if (!app.Environment.IsDevelopment()).

Key Changes:

  • Updated documentation heading to correctly describe non-development environment middleware configuration

Next, the HTTP request pipeline is configured.

In the development environment:
When the app isn't running in the Development environment:
Copy link
Contributor

@wadepickett wadepickett Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit and I could see it either way, but seems like we might use code ticks around "Development" here if it is to be capitalized.

Copy link
Collaborator Author

@guardrex guardrex Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been unable to stick to a convention on this one 😢. I'm going to make a tracking item entry to go through all of the Blazor docs and make it consistent. I'll go code style on the next commit; and with @tdykstra, you can let me know which convention you ultimately settle on. It sounds like for now that we'll code style the environment names.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vote goes for code style.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well ..... I've been about 50-50 on it one way or the other I'm sorry to say on this one 🙈😆.

Because this is a low priority item to address, I've made a tracking entry on it. I'll circle around later, open an issue, and knock it out.

@guardrex guardrex mentioned this pull request Dec 2, 2025
93 tasks
@guardrex guardrex merged commit ab5bb79 into main Dec 2, 2025
4 checks passed
@guardrex guardrex deleted the guardrex-patch-1 branch December 2, 2025 19:27
@guardrex guardrex removed the request for review from tdykstra December 2, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blazor movie database sample (Part 1): "In the development environment:" should be "Not in the development environment:"

4 participants