-
Notifications
You must be signed in to change notification settings - Fork 25.1k
[11.0 P1] Blazor Web can use BasePath component instead of <base href="">
#36428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
guardrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ilonatommy! This is great content. I made a handful of suggestions.
We also need a versioned entry for the component with cross-link at ...
I'll search the repo for specific instances of the <base> tag to see if other changes are needed.
Also ... by "stash" I think you mean until the preview lands. Which preview is this for? I still need to set up the 11.0 doc tracking. I'll make sure this is tracked when I set that up.
|
@ilonatommy ... I checked ... and Yes! ... it seems that we'll need a round of small changes to address this in other places where the |
BasePath component instead of <base href="">BasePath component instead of <base href="">
|
@wadepickett @tdykstra ... It's that time again! 😆 ........
|
There's no hurry, it's just an early draft so that we don't forget about it when the feature gets merged. |
|
Which preview will this be for? ... and I track with links to the PU issue/PR. |
We're targeting p1. |
BasePath component instead of <base href="">BasePath component instead of <base href="">
Co-authored-by: Luke Latham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ... will hold now until P1 ships, and I'll get this into the new release notes. I'll probably be the one setting up release notes just because we'll have early Blazor coverage.
@wadepickett or @tdykstra will probably take care of the 11.0 moniker soon.
I've opened #36429 to address the last updates for this.
Doc changes proposal for dotnet/aspnetcore#64590.
Internal previews