Bugfix MetricColumn: Respect unit when formatting values.

The previous implementation would only use the given unit if SummaryStyle.PrintUnitsInContent was true, otherwise it would fallback to the default unit, regardless whether SummaryStyle.PrintUnitsInHeader was true or not. This fix takes both SummaryStyle.PrintUnitsIn* into account.

It should be noted that other columns than the MetricColumn do **not** take the visibility of units into account and always use the given unit, be it explicitly selected by the user, or calculated via GetBest*Unit().

Author: mawosoft

src/BenchmarkDotNet/Columns/MetricColumn.cs

@@ -1,6 +1,7 @@
 using System.Linq;
 using BenchmarkDotNet.Reports;
 using BenchmarkDotNet.Running;
+using Perfolizer.Common;
 using Perfolizer.Horology;
 
 namespace BenchmarkDotNet.Columns
@@ -33,12 +34,15 @@ public string GetValue(Summary summary, BenchmarkCase benchmarkCase, SummaryStyl
 
             var cultureInfo = summary.GetCultureInfo();
 
-            if (style.PrintUnitsInContent && descriptor.UnitType == UnitType.CodeSize)
-                return SizeValue.FromBytes((long)metric.Value).ToString(style.CodeSizeUnit, cultureInfo, descriptor.NumberFormat);
-            if (style.PrintUnitsInContent && descriptor.UnitType == UnitType.Size)
-                return SizeValue.FromBytes((long)metric.Value).ToString(style.SizeUnit, cultureInfo, descriptor.NumberFormat);
-            if (style.PrintUnitsInContent && descriptor.UnitType == UnitType.Time)
-                return TimeInterval.FromNanoseconds(metric.Value).ToString(style.TimeUnit, cultureInfo);
+            bool printUnits = style.PrintUnitsInContent || style.PrintUnitsInHeader;
+            UnitPresentation unitPresentation = UnitPresentation.FromVisibility(style.PrintUnitsInContent);
+
+            if (printUnits && descriptor.UnitType == UnitType.CodeSize)
+                return SizeValue.FromBytes((long)metric.Value).ToString(style.CodeSizeUnit, cultureInfo, descriptor.NumberFormat, unitPresentation);
+            if (printUnits && descriptor.UnitType == UnitType.Size)
+                return SizeValue.FromBytes((long)metric.Value).ToString(style.SizeUnit, cultureInfo, descriptor.NumberFormat, unitPresentation);
+            if (printUnits && descriptor.UnitType == UnitType.Time)
+                return TimeInterval.FromNanoseconds(metric.Value).ToString(style.TimeUnit, cultureInfo, descriptor.NumberFormat, unitPresentation);
 
             return metric.Value.ToString(descriptor.NumberFormat, cultureInfo);
         }