Revert remove old runtimes #2692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated MultipleFrameworks tests.
timcassell
force-pushed
the
revert-remove-old-runtimes
branch
from
607c682 to
df29aba
Compare
adamsitnik
requested changes
Jan 30, 2025
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
@timcassell thank you for your contribution!
I am fine with restoring the support for .NET Core 2.0, but:
- all our docs and samples should be using supported TFMs (net8.0 and net9.0)
- the parsing tests should cover both old and new tfms as string inputs
- the test projects should keep running as net8.0
I hope that my suggestion won't be too much work (it should be a matter of few reverts here and there).
tests/BenchmarkDotNet.IntegrationTests.ManualRunning/LocalNativeAotToolchainTests.cs
Outdated
Show resolved
Hide resolved
timcassell
force-pushed
the
revert-remove-old-runtimes
branch
from
13a52ca to
75274f9
Compare
Collaborator
Author
|
@adamsitnik I think I addressed all of your feedback. |
adamsitnik
approved these changes
Jan 31, 2025
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @timcassell !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2505, re-enabling old runtimes back to netcoreapp2.0 by utilizing
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>(thanks to the solution by @adamsitnik in #2686).