Skip to content

Minimum required changes for working tests #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galvesribeiro merged 16 commits into from
Jan 28, 2021
Merged

Minimum required changes for working tests #481

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ded1b4d
Updated models and fixed tests
Jan 11, 2021
f9dd969
Discarded model
Jan 11, 2021
4cc11b9
Failing tests on CI/CD
Jan 11, 2021
2ef06ed
Debugging tests on CI/CD
Jan 11, 2021
acf9b19
Applied PR suggested changes
Jan 13, 2021
15ebea8
error when running tests on CI/CD pipeline
Jan 13, 2021
7e23974
Implemented approach from PR #343 for cancelling streamReader
Jan 14, 2021
e56935f
Tests case is behaving differently while it runs on CI/CD pipeline
Jan 14, 2021
860b53b
Merged changes from author fork
Oct 15, 2020
3fca955
Error on CI/CD pipeline due to new Message.Status. Discarted Message.…
Jan 15, 2021
353014a
Serialization for IList<byte> to base64
Jan 19, 2021
e21a71b
PR suggestions by @galvesriverio
Jan 20, 2021
73bcc76
Updated test for DockerService_IsRunning
Jan 20, 2021
402b8ad
Renamed process name in tests
Jan 21, 2021
5369ddf
Updated version for Nerdbank.GitVersioning
Jan 21, 2021
91ab832
Updated ProcesName in test
Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions test/Docker.DotNet.Tests/ISystemOperations.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.ServiceProcess;
using System.Threading;
using System.Threading.Tasks;
using Docker.DotNet.Models;
Expand All @@ -18,15 +18,11 @@ public ISystemOperationsTests()
_client = new DockerClientConfiguration().CreateClient();
}

[SupportedOSPlatformsFact(Platform.Windows)]
public void DockerService_IsRunning()
[Fact]
public void Docker_IsRunning()
{
var services = ServiceController.GetServices();
using (var dockerService = services.FirstOrDefault(service => service.ServiceName == "docker" || service.ServiceName == "com.docker.service"))
{
Assert.NotNull(dockerService); // docker is not running
Assert.Equal(ServiceControllerStatus.Running, dockerService.Status);
}
var dockerProcess = Process.GetProcesses().FirstOrDefault(_ => _.ProcessName == "docker" || _.ProcessName == "com.docker.service");
Assert.NotNull(dockerProcess); // docker is not running
}

[Fact]
Expand Down