Fixed CI build by skipping Bad Test

[james-gould]

The docker.exe process is not always running, so this test fails due to luck/timing.

If docker.exe wasn't running, the other tests would fail as the TestFixture.DockerClient would not be able to communicate with the local system's Docker instance.

[james-gould]

@dotnet-policy-service agree

[james-gould]

The repo has had a lot of fixes and improvements since the last successful NuGet release on May 18th 2023. I ran into a bug raised as an issue in #663 and wanted to fix it, turns out the fix is already in place but the release hasn't gone out for a while.

[james-gould]

Removed to mirror the updated type: https://github.com/moby/moby/blob/master/api/types/container/hostconfig.go#L283

Caused the updated System.Text.Json and System.Net.Http.Json serializers to fail due to empty strings not being valid.

All tests passing after this squash too.

[james-gould]

This resolved a critical vulnerability in the transitive Newtonsoft.Json dependency

[james-gould]

Also concious of the version being behind, the current Docker API is v1.47 so the updated SEMVAR would be 3.147.0. Not sure what the etiquette is for updating the version, if you'd like me to put that in the PR too let me know.

[james-gould]

Not sure why my CI is failing on Github when locally the tests are working fine. Not familiar with Docker inside of a CI runner - any reason why this might be working locally but failing on Github? Even adding some trace logs reveals all looks fine - but it's fails.

https://github.com/james-gould/Docker.DotNet/actions/runs/13230419475

[HofmeisterAn]

I would like to share that there is a forked version that resolves the issue without removing the enum value. According to the Docker Engine API documentation, "" is a valid value.

[james-gould]

Thanks Andre, didn't realise there was a maintained fork. Will port my dep over and abandon this - clearly not my finest work!