This repository was archived by the owner on Dec 21, 2023. It is now read-only.
Open
Conversation
Contributor
Author
|
We need this PR as a preliminary step to fix #250 |
hartez
previously approved these changes
Jun 22, 2022
Contributor
|
This adds a significant performance and memory hit. The library should be able to re-use the underlying native image representations, especially when you need to do something like tile an image. |
hartez
requested review from
hartez and
jonlipsky
and removed request for
hartez
Contributor
|
@hartez @jsuarezruiz This will need a more involved fix. The problem is that with Direct2D you have limitations about using resources between contexts. In some cases, the proposed solution would be acceptable but in most cases it's not acceptable from the aforementioned memory and performance issues. I should have some time tomorrow to look at a permanent solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
DrawImagemethod on Windows