Merge pull request #1213 from dotnet/msbuildCaseInsensitive

msbuildCaseInsensitive

Author: AArnott

src/nbgv/Program.cs

@@ -393,7 +393,9 @@ private static async Task<int> OnInstallCommand(string path, string version, str
                 context.Stage(directoryPackagesPropsPath);
             }
 
-            ProjectItemElement item = propsFile.Items.FirstOrDefault(i => i.ItemType == PackageReferenceItemType && i.Include == PackageId);
+            ProjectItemElement item = propsFile.Items.FirstOrDefault(i =>
+                string.Equals(i.ItemType, PackageReferenceItemType, StringComparison.OrdinalIgnoreCase) &&
+                string.Equals(i.Include, PackageId, StringComparison.OrdinalIgnoreCase));
 
             if (item is null)
             {
@@ -418,7 +420,8 @@ private static async Task<int> OnInstallCommand(string path, string version, str
                 if (isCpmEnabled)
                 {
                     // Remove Version metadata if CPM is enabled
-                    ProjectMetadataElement versionMetadata = item.Metadata.FirstOrDefault(m => m.Name == VersionMetadataName);
+                    ProjectMetadataElement versionMetadata = item.Metadata.FirstOrDefault(m =>
+                        string.Equals(m.Name, VersionMetadataName, StringComparison.OrdinalIgnoreCase));
                     if (versionMetadata is not null)
                     {
                         item.RemoveChild(versionMetadata);
@@ -427,7 +430,8 @@ private static async Task<int> OnInstallCommand(string path, string version, str
                 else
                 {
                     // Update Version metadata if CPM is not enabled
-                    ProjectMetadataElement versionMetadata = item.Metadata.FirstOrDefault(m => m.Name == VersionMetadataName);
+                    ProjectMetadataElement versionMetadata = item.Metadata.FirstOrDefault(m =>
+                        string.Equals(m.Name, VersionMetadataName, StringComparison.OrdinalIgnoreCase));
                     if (versionMetadata is not null)
                     {
                         versionMetadata.Value = packageVersion;
@@ -926,7 +930,8 @@ private static void UpdateDirectoryPackagesProps(string path, string packageId,
             const string VersionMetadataName = "Version";
 
             ProjectItemElement item = propsFile.Items.FirstOrDefault(i =>
-                i.ItemType == PackageVersionItemType && i.Include == packageId);
+                string.Equals(i.ItemType, PackageVersionItemType, StringComparison.OrdinalIgnoreCase) &&
+                string.Equals(i.Include, packageId, StringComparison.OrdinalIgnoreCase));
 
             if (item is null)
             {
@@ -940,7 +945,8 @@ private static void UpdateDirectoryPackagesProps(string path, string packageId,
             }
             else
             {
-                ProjectMetadataElement versionMetadata = item.Metadata.FirstOrDefault(m => m.Name == VersionMetadataName);
+                ProjectMetadataElement versionMetadata = item.Metadata.FirstOrDefault(m =>
+                    string.Equals(m.Name, VersionMetadataName, StringComparison.OrdinalIgnoreCase));
                 if (versionMetadata is not null)
                 {
                     versionMetadata.Value = packageVersion;