-
Notifications
You must be signed in to change notification settings - Fork 579
Remove generic builder pattern from element metadata creation (Part 1) #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeebowen
previously approved these changes
Nov 27, 2024
tomjebo
previously approved these changes
Mar 27, 2025
mikeebowen
previously approved these changes
Mar 27, 2025
mikeebowen
approved these changes
Mar 31, 2025
tomjebo
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of what will probably be a few PRs to replace the generic builder pattern in use for defining element metadata. This causes a lot of JITing to occur and causes the ballooning of AOT builds.
Looks like around 5% faster while doing a file read and has removed about 25% of the generic types
Before
After