Conversation
Test Results 66 files - 4 66 suites - 4 1h 10m 1s ⏱️ + 6m 0s Results for commit b227f3e. ± Comparison against base commit 09a06c8. This pull request removes 599 and adds 599 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
PR Overview
This pull request updates the testing infrastructure to support XUnit v3. Key changes include:
- Temporarily disabling the code coverage workflow step in .github/workflows/code-coverage.yml.
- Updating the dotnet test command in .github/workflows/build.yml to use new XUnit v3 flags and modifying the artifact upload path.
- Removing references to Xunit.Abstractions across several test files and deleting an obsolete source generator verifier test file.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/code-coverage.yml | Added a temporary disable condition for the job while integrating XUnit v3 |
| .github/workflows/build.yml | Updated test command and artifact path to align with XUnit v3 reporting |
| test/Common/VerifiableLog.cs, ObjectSizeTests.cs, ParticleTests.cs, ElementLookupTests.cs, PartConstraintRuleTests.cs | Removed reference to Xunit.Abstractions |
| test/Common/ITestOutputHelperExtenstions.cs | Changed using from Xunit.Abstractions to Xunit (note potential file name typo) |
| test/DocumentFormat.OpenXml.Generator.Tests/Verifiers/OpenXmlIncrementalSourceGeneratorVerifier.cs | Removed obsolete source generator verifier tests |
Copilot reviewed 62 out of 62 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
.github/workflows/code-coverage.yml:23
- Disabling the code coverage step may lead to missing coverage metrics. Consider adding a TODO or reference issue to re-enable this step once XUnit v3 integration is complete.
if: false # Disable for now while getting XUnit v3 working
.github/workflows/build.yml:99
- Verify that the updated test command using '--report-xunit-trx' is fully compatible with XUnit v3 and that any removal of previous logger options does not affect test reporting.
run: dotnet test --no-restore -- --results-directory ${{ github.workspace }}/test-results/ --report-xunit-trx
test/DocumentFormat.OpenXml.Generator.Tests/Verifiers/OpenXmlIncrementalSourceGeneratorVerifier.cs:1
- The removal of this source generator verifier file could reduce test coverage for the source generator functionality. Ensure that equivalent tests exist or that additional coverage is provided.
Entire file removal
| using Newtonsoft.Json.Converters; | ||
| using System.IO; | ||
| using Xunit.Abstractions; | ||
| using Xunit; |
There was a problem hiding this comment.
The file name 'ITestOutputHelperExtenstions.cs' appears to contain a typographical error; consider renaming it to 'ITestOutputHelperExtensions.cs' for clarity.
No description provided.