Merged
Conversation
Collaborator
mikeebowen
commented
Mar 19, 2025
mikeebowen
commented
- closes Writing asynchronously with OpenXmlWriter #913
twsouthwick
requested changes
Mar 24, 2025
twsouthwick
requested changes
Mar 25, 2025
Member
twsouthwick
left a comment
twsouthwick
left a comment
There was a problem hiding this comment.
Looking good - with this new settings object, it can be made available everywhere, except that the Async property would be around the if/def
twsouthwick
previously approved these changes
Mar 26, 2025
Member
twsouthwick
left a comment
twsouthwick
left a comment
There was a problem hiding this comment.
Just a nit, but overall good!
tomjebo
approved these changes
Mar 26, 2025
twsouthwick
approved these changes
Mar 27, 2025
Member
twsouthwick
left a comment
twsouthwick
left a comment
There was a problem hiding this comment.
Take a look at the docs, then it's good to merge
| { | ||
| #if FEATURE_ASYNC_SAX_XML | ||
| /// <summary> | ||
| /// Gets or sets a value indicating whether asynchronous OpenXmlPartWriter methods can be used. |
Member
There was a problem hiding this comment.
Suggested change
| /// Gets or sets a value indicating whether asynchronous OpenXmlPartWriter methods can be used. | |
| /// Gets or sets a value indicating whether asynchronous <see cref="OpenXmlPartWriter" /> methods can be used. |
| #endif | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets a value indicating whether the OpenXmlPartWriter should check to ensure that all characters in the document conform to the "2.2 Characters" section of the W3C XML 1.0 Recommendation. |
Member
There was a problem hiding this comment.
Suggested change
| /// Gets or sets a value indicating whether the OpenXmlPartWriter should check to ensure that all characters in the document conform to the "2.2 Characters" section of the W3C XML 1.0 Recommendation. | |
| /// Gets or sets a value indicating whether the <see cref="OpenXmlPartWriter" /> should check to ensure that all characters in the document conform to the "2.2 Characters" section of the W3C XML 1.0 Recommendation. |
Do you have a link to that part of the docs?
Member
There was a problem hiding this comment.
Is that really what the "CloseOutput" property does?
| public bool CloseOutput { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets a value indicating whether the OpenXmlPartWriter should also close the underlying stream or TextWriter when the Close() method is called. |
Member
There was a problem hiding this comment.
I think these summaries are off...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.