-
Notifications
You must be signed in to change notification settings - Fork 568
Add Check for empty parts to OpenXmlValidator #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikeebowen
wants to merge
41
commits into
dotnet:main
Choose a base branch
from
mikeebowen:issue-816
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
794484d
add IsValidChild method for WordprocessingDocument
mikeebowen 9f65d67
add IsValidDocument method for SpreadsheetDocument
mikeebowen b67a9bf
Add IsMinimumDocument method for Presentation
mikeebowen 6b9d2aa
update tests and xml comments
mikeebowen 61192e4
Merge remote-tracking branch 'upstream/main' into issue-816
mikeebowen 0d6de91
Merge remote-tracking branch 'upstream/main' into issue-816
mikeebowen e9cca0a
Merge branch 'main' into issue-816
mikeebowen 84edcb0
Merge branch 'issue-816' of github.com:mikeebowen/Open-XML-SDK into i…
mikeebowen 48afb54
only test null argument for < .Net 8+
mikeebowen f83d1d0
move Wordprocessing minimum document validation to virtual method
mikeebowen 8dc68ef
Change minimum Word doc API to OpenSettings options
mikeebowen 1a0d73a
add VerifyMinimumPackage option to PresentationDocument
mikeebowen 8ba0e4d
fix linting issues
mikeebowen 55e3eef
remove trailing whitespace
mikeebowen 69a5900
remove unnecessary $ from string
mikeebowen 9bc42e2
remove unnecessary usings
mikeebowen 3a0c367
use feature for minimum document
twsouthwick fca841a
a bit more
twsouthwick b46015b
Merge pull request #3 from twsouthwick/use-feature
mikeebowen a4b61a7
move VerfiyMinimumPackage to feature
mikeebowen 8e1d50d
remove ThrowIfNotMinimumPackage from OpenXmlPackage
mikeebowen 8d1d6ea
fix merge conflict
mikeebowen 04ef42b
verify wordprocessing document
mikeebowen a236566
add minimum document validation for PowerPoint and Excel
mikeebowen af392cc
add tests
mikeebowen b6d9b45
Merge branch 'issue-816' of github.com:mikeebowen/Open-XML-SDK into i…
mikeebowen 7d4c2b4
revert to match main
mikeebowen 8c4d993
add validation error if part is empty
mikeebowen 12699db
update how to check for empty parts
mikeebowen 8772882
fix tests
mikeebowen a1847d7
custom file property part test passes
mikeebowen 92dcc74
fix P002_Pptx_DeleteAdd_CoreExtendedProperties test
mikeebowen 1df4b0b
fix X006_Xlsx_DeleteAdd_CoreExtendedProperties and W051_AddNewPart_To…
mikeebowen 1cdf8d2
Merge remote-tracking branch 'upstream/main' into issue-816
mikeebowen d7ee41b
add blank line
mikeebowen 2097f05
remove file from earlier version of API
mikeebowen 31aec5a
add IsEmptyPart method to ensure stream is disposed
mikeebowen 2d5dd09
Update src/DocumentFormat.OpenXml.Framework/Packaging/OpenXmlPart.cs
mikeebowen e911447
Merge remote-tracking branch 'upstream/main' into issue-816
mikeebowen 4861f13
move file extension check to IsEmptyPartMethod
mikeebowen 25e5c67
removed unnecessary using
mikeebowen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.