Skip to content

Conversation

@Khitiara
Copy link
Contributor

Summary of the PR

A proposal for changes, some of them breaking, to the managed chain utilities for 3.0.

Related issues, Discord discussions, or proposals

As discussed in discord with the SilkX team.

@Khitiara Khitiara requested a review from a team as a code owner November 11, 2023 02:19
@Perksey Perksey added this to the Next Working Group Meeting milestone Nov 11, 2023
@Perksey
Copy link
Member

Perksey commented Nov 11, 2023

Can you add .md to the filename

@Perksey
Copy link
Member

Perksey commented Nov 11, 2023

No pre-WG comments here

@curin
Copy link
Contributor

curin commented Nov 14, 2023

No comments from me, either, but VK is also not my area of expertise, so I'm just going off of the proposal working as explained.

@Perksey
Copy link
Member

Perksey commented Nov 19, 2023

  • We believe that the chain abstractions break down significantly anyway when used as an output with layers that can possibly inject additional PNexts that aren't reflected in these abstractions.
  • As a result, this chain abstraction only really works with inputs in every case.
  • UntypedHeadPtr being changed from BaseInStructure is contrary to this assumption.
  • Why is it IStructuredType instead of ITypedStructure? Changing this doesn't affect too much, but leaving it as is doesn't affect too much either.
  • 3.0 is the opportunity to fix long-standing issues like this as it's already massively breaking, so we can do silly changes like this.
  • IStructuredType is already broken with this proposal, so let's just rename it anyway.
  • We believe that IBaseStructure is probably the most sensible name given how Vulkan names this.
  • Everything else looks fine, approved notwithstanding the above.

@Perksey Perksey merged commit d4d5534 into dotnet:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants