Skip to content

Gracefully map unknown or invalid Input.Key to ImGuiKey.None. #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perksey merged 2 commits into from
May 26, 2025
Merged

Gracefully map unknown or invalid Input.Key to ImGuiKey.None. #2458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8af883
start of ImGui unknown key mapping fix.
Tweety-Lab May 26, 2025
256cecb
Gracefully map invalid `Input.Key` to `ImGuiKey.None`.
Tweety-Lab May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/OpenGL/Extensions/Silk.NET.OpenGL.Extensions.ImGui/ImGuiController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ internal void PressChar(char keyChar)
/// </summary>
/// <param name="key">The Silk.NET.Input.Key to translate.</param>
/// <returns>The corresponding ImGuiKey.</returns>
/// <exception cref="NotImplementedException">When the key has not been implemented yet.</exception>
private static ImGuiKey TranslateInputKeyToImGuiKey(Key key)
{
return key switch
Expand Down Expand Up @@ -409,7 +408,7 @@ private static ImGuiKey TranslateInputKeyToImGuiKey(Key key)
Key.F22 => ImGuiKey.F22,
Key.F23 => ImGuiKey.F23,
Key.F24 => ImGuiKey.F24,
_ => throw new NotImplementedException(),
_ => ImGuiKey.None, // Key isn't implemented
};
}

Expand Down
Loading