Skip to content

[3.0] Fix EnumGroupRegression test case #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silkdotnet merged 1 commit into from
Jan 2, 2026
Merged

[3.0] Fix EnumGroupRegression test case #2525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sources/SilkTouch/SilkTouch/Mods/MixKhronosData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2278,7 +2278,7 @@ var group in (groupName is null ? Enumerable.Empty<string>() : [groupName])
}

// Some enum groups don't have members, meaning that the code above won't catch them
if (groupName != null && !data.Groups.ContainsKey(groupName))
if (groupName != null && !IsUngroupable(groupName) && !data.Groups.ContainsKey(groupName))
{
data.Groups[groupName] = new EnumGroup(
groupName,
Expand Down
2 changes: 2 additions & 0 deletions ...s/SilkTouch/SilkTouch/Khronos/MixKhronosDataTests.EnumGroupRegression.cl.xml.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Added Group: cl_arm_svm_alloc_flags
Existing Group: cl_command_queue_properties
Added: CL_QUEUE_RESERVED_QCOM

Added Group: cl_compiler_mode_altera

Added Group: cl_device_command_buffer_capabilities_khr
Added: CL_COMMAND_BUFFER_CAPABILITY_DEVICE_SIDE_ENQUEUE_KHR
Added: CL_COMMAND_BUFFER_CAPABILITY_KERNEL_PRINTF_KHR
Expand Down
Loading