Flatten | SqlInternalConnectionTds and SqlInternalConnection#3773

Open

benrr101 wants to merge 35 commits intomainfrom

dev/russellben/flatten/sqlinternalconnection

Commits on Nov 18, 2025

Change all possible references from SqlInternalConnection to SqlInternalConnectionTds
benrr101
committed
Move BeginTransaction and BeginSqlTransaction into SqlInternalConnectionTds.cs
benrr101
committed
Move ChangeDatabase into SqlInternalConnectionTds, move ChangeDatabaseInternal into ChangeDatabase, remove abstract ChangeDatabaseInternal
benrr101
committed
Move EnlistTransaction to SqlInternalConnectionTds
benrr101
committed
Remove abstract ValidateConnectionForExecute
benrr101
committed
Move Enlist into SqlInternalConnectionTds
benrr101
committed
Move EnlistNonNull into SqlInternalConnectionTds
benrr101
committed
Move EnlistNull into SqlInternalConnectionTds
benrr101
committed
Removed no longer necessary abstractions in SqlInternalConnection
benrr101
committed
Move OnError into SqlInternalConnectionTds
benrr101
committed
Move Deactivate into SqlInternalConnectionTds, merge InternalDeactivate into Deactivate
benrr101
committed
Move GetTransactionCookie into SqlInternalConnectionTds
benrr101
committed
Move FindLiveReader into SqlInternalConnectionTds
benrr101
committed
Merge SqlInternalConnection.Dispose into SqlInternalConnectionTds
benrr101
committed
Move CleanupTransactionOnCompletion, CreateReferenceCollection into SqlInternalConnectionTds
benrr101
committed
Introduce a CachedContexts class, move the cached call contexts from SqlInternalConnection into that. Migrate usages of ExecuteReaderAsyncCallContext to the new class.
benrr101
committed
Migrate usages of CachedCommandExecuteNonQueryAsyncContext to the new class.
benrr101
committed
Migrate usages of CachedCommandExecuteXmlReaderAsyncContext to the new class
benrr101
committed
Migrate usage of ReadAsyncCallContext to the new class
benrr101
committed
Migrate usage of IsDBNullAsyncCallContext to the new class.
benrr101
committed
Comments on CachedContexts
benrr101
committed
Sure why not move the reader snapshot into the CachedContexts class? the usages of it are basically doing the same thing
benrr101
committed
Move _whereAbouts and s_globalTransactionTMID
benrr101
committed
Merge constructors
benrr101
committed
Merge AvailableInternalTransaction, CurrentTransaction, HasLocalTransaction, HasLocalTransactionFromAPI
benrr101
committed
Merge Connection, ConnectionOptions, CurrentDatabase, CurrentDataSource, DelegatedTransaction, Is2008OrNewer, IsAzureSqlConnection, IsEnlistedInTransaction, IsGlobalTransaction, IsGlobalTransaction…
benrr101
committed
Remove SqlInternalConnection
benrr101
committed
Move SqlInternalConnectionTds.cs to SqlConnectionInternal.cs
benrr101
committed
Renane Microsoft.Data.SqlClient.SqlInternalConnectionTds to Microsoft.Data.SqlClient.Connection.SqlInternalConnectionTds
benrr101
committed
Fix one reference to SqlInternalConnectionTds in unit tests
benrr101
committed
As per copilot comment, rewriting a block in SqlConnectionFactory to use a using block. Also removing redundant if statement condition.
benrr101
committed
As per copilot comment, adding more comments to CachedContexts class
benrr101
committed

Commits on Dec 1, 2025

Addressing some feedback from @mdiagle
benrr101
committed

Commits on Dec 2, 2025