Skip to content

Conversation

@edwardneal
Copy link
Contributor

@edwardneal edwardneal commented Nov 23, 2025

Description

This continues mop-up work which started to come into focus during the merge. It also lays the groundwork for two pieces of future work.

There were a handful of members which were never used. This PR removes them.

We also lay the groundwork for two future pieces of work:

  1. Removing unused members from SqlUtil.cs and AdapterUtil.cs also removes references to a few resource strings. When this and Cleanup | Merge SqlTypes resource string methodology #3733 are both merged, we'll be in a position to clearly determine which resource strings are truly unused, then to remove them.
  2. The minor cleanup of DbReferenceCollection removes the ability to pass a message to the data reader, command or bulk copy associated with a connection whcih is being deactivated. This was never used, and it highlights that DbReferenceCollection and SqlReferenceCollection are simply a list of weak references to those objects. ConditionalWeakTable<TKey, TValue> might now be able to replace the functionality of these classes.

Issues

None, although it follows up from the merge work.

Testing

Automated tests pass, although realistically a simple CI run should validate this.

@edwardneal edwardneal requested a review from a team as a code owner November 23, 2025 22:54
@edwardneal edwardneal changed the title Cleanup | remove unused members Cleanup | Remove unused members Nov 23, 2025
@paulmedynski paulmedynski self-assigned this Nov 24, 2025
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mdaigle mdaigle added this to the 7.0.0-preview3 milestone Nov 24, 2025
Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw man, you're doing all the fun stuff 😝 Thanks for these!

@paulmedynski paulmedynski merged commit 728f467 into dotnet:main Nov 28, 2025
246 of 248 checks passed
@edwardneal edwardneal deleted the cleanup/remove-unused-members branch November 28, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants