Cleanup | Remove unused members #3803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This continues mop-up work which started to come into focus during the merge. It also lays the groundwork for two pieces of future work.
There were a handful of members which were never used. This PR removes them.
We also lay the groundwork for two future pieces of work:
DbReferenceCollectionremoves the ability to pass a message to the data reader, command or bulk copy associated with a connection whcih is being deactivated. This was never used, and it highlights thatDbReferenceCollectionandSqlReferenceCollectionare simply a list of weak references to those objects.ConditionalWeakTable<TKey, TValue>might now be able to replace the functionality of these classes.Issues
None, although it follows up from the merge work.
Testing
Automated tests pass, although realistically a simple CI run should validate this.