Skip to content

Disable Sql*ReliabilityTests on Azure #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2025
+34 −17
Merged

Disable Sql*ReliabilityTests on Azure #3823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7625e0f
Disable for azure.
mdaigle Dec 2, 2025
9e1d2bc
Restrict command reliability tests to non-azure.
mdaigle Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/SqlCommandReliabilityTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ protected virtual void Dispose(bool disposing)
numberOfRetries: 2,
maxInterval: TimeSpan.FromMilliseconds(100));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(RetryExecuteFail_Data), DisableDiscoveryEnumeration = true)]
public void RetryExecuteFail(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -101,7 +102,8 @@ public void RetryExecuteFail(string cnnString, SqlRetryLogicBaseProvider provide
numberOfRetries: 2,
maxInterval: TimeSpan.FromMilliseconds(100));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(RetryExecuteCancel_Data), DisableDiscoveryEnumeration = true)]
public void RetryExecuteCancel(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -151,7 +153,8 @@ public void RetryExecuteCancel(string cnnString, SqlRetryLogicBaseProvider provi
numberOfRetries: 5,
maxInterval: TimeSpan.FromMilliseconds(100));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(RetryExecuteWithTransactionScope_Data), DisableDiscoveryEnumeration = true)]
public void RetryExecuteWithTransScope(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -192,7 +195,8 @@ public void RetryExecuteWithTransScope(string cnnString, SqlRetryLogicBaseProvid
maxInterval: TimeSpan.FromMilliseconds(100));

// Synapse: 111214;An attempt to complete a transaction has failed. No corresponding transaction found.
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(RetryExecuteWithTransaction_Data), DisableDiscoveryEnumeration = true)]
public void RetryExecuteWithTransaction(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -236,7 +240,8 @@ public void RetryExecuteWithTransaction(string cnnString, SqlRetryLogicBaseProvi
unauthorizedStatementRegex: RetryLogicTestHelper.FilterDmlStatements);

// Synapse: Msg 103010, Level 16, State 1, Line 1 | Parse error at line: 1, column: 1: Incorrect syntax near 'command'
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(RetryExecuteUnauthorizedSqlStatementDml_Data), DisableDiscoveryEnumeration = true)]
public void RetryExecuteUnauthorizedSqlStatementDml(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -363,7 +368,8 @@ public void DropDatabaseWithActiveConnection(string cnnString, SqlRetryLogicBase

// In Managed SNI by Named pipe connection, SqlCommand doesn't respect timeout. "ActiveIssue 12167"
// Synapse: Does not support WAITFOR DELAY.
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotUsingManagedSNIOnWindows), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotUsingManagedSNIOnWindows), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(UpdateLockedTable_Data), DisableDiscoveryEnumeration = true)]
public void UpdateLockedTable(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -423,7 +429,8 @@ public void UpdateLockedTable(string cnnString, SqlRetryLogicBaseProvider provid
public static TheoryData<string, SqlRetryLogicBaseProvider> NoneRetriableExecuteFail_Data =>
RetryLogicTestHelper.GetNonRetriableCases();

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(NoneRetriableExecuteFail_Data), DisableDiscoveryEnumeration = true)]
public void NoneRetriableExecuteFail(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -463,7 +470,8 @@ public void NoneRetriableExecuteFail(string cnnString, SqlRetryLogicBaseProvider
numberOfRetries: 2,
maxInterval: TimeSpan.FromMilliseconds(100));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(RetryExecuteAsyncFail_Data), DisableDiscoveryEnumeration = true)]
public async Task RetryExecuteAsyncFail(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -533,7 +541,8 @@ public async Task RetryExecuteAsyncFail(string cnnString, SqlRetryLogicBaseProvi
numberOfRetries: 2,
maxInterval: TimeSpan.FromMilliseconds(100));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(RetryExecuteAsyncCancel_Data), DisableDiscoveryEnumeration = true)]
public async Task RetryExecuteAsyncCancel(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -606,7 +615,8 @@ public async Task RetryExecuteAsyncCancel(string cnnString, SqlRetryLogicBasePro
numberOfRetries: 2,
maxInterval: TimeSpan.FromMilliseconds(100));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(ConcurrentExecution_Data), DisableDiscoveryEnumeration = true)]
public void ConcurrentExecution(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand All @@ -628,7 +638,8 @@ public void ConcurrentExecution(string cnnString, SqlRetryLogicBaseProvider prov
numberOfRetries: 2,
maxInterval: TimeSpan.FromMilliseconds(100));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(ConcurrentExecutionAsync_Data), DisableDiscoveryEnumeration = true)]
public async Task ConcurrentExecutionAsync(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down
18 changes: 12 additions & 6 deletions ...Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/SqlConnectionReliabilityTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ public class SqlConnectionReliabilityTest
deltaTime: TimeSpan.FromMilliseconds(250));

// Test relies on error 4060 for automatic retry, which is not reliable when using Azure or AAD auth
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(ConnectionRetryOpenInvalidCatalogFailed_Data), DisableDiscoveryEnumeration = true)]
public void ConnectionRetryOpenInvalidCatalogFailed(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand All @@ -48,7 +49,8 @@ public void ConnectionRetryOpenInvalidCatalogFailed(string cnnString, SqlRetryLo
deltaTime: TimeSpan.FromMilliseconds(250));

// Test relies on error 4060 for automatic retry, which is not reliable when using Azure or AAD auth
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(ConnectionCancelRetryOpenInvalidCatalog_Data), DisableDiscoveryEnumeration = true)]
public void ConnectionCancelRetryOpenInvalidCatalog(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -124,7 +126,8 @@ public void CreateDatabaseWhileTryingToConnect(string cnnString, SqlRetryLogicBa
maxInterval: TimeSpan.FromSeconds(1),
deltaTime: TimeSpan.FromMilliseconds(250));

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(ConcurrentExecution_Data), DisableDiscoveryEnumeration = true)]
public void ConcurrentExecution(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down Expand Up @@ -159,7 +162,8 @@ public void ConcurrentExecution(string cnnString, SqlRetryLogicBaseProvider prov
public static TheoryData<string, SqlRetryLogicBaseProvider> DefaultOpenWithoutRetry_Data =>
RetryLogicTestHelper.GetNonRetriableCases();

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(DefaultOpenWithoutRetry_Data), DisableDiscoveryEnumeration = true)]
public void DefaultOpenWithoutRetry(string connectionString, SqlRetryLogicBaseProvider cnnProvider)
{
Expand Down Expand Up @@ -191,7 +195,8 @@ public void DefaultOpenWithoutRetry(string connectionString, SqlRetryLogicBasePr
deltaTime: TimeSpan.FromMilliseconds(250));

// Test relies on error 4060 for automatic retry, which is not reliable when using Azure or AAD auth
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(ConnectionRetryOpenAsyncInvalidCatalogFailed_Data), DisableDiscoveryEnumeration = true)]
public async Task ConnectionRetryOpenAsyncInvalidCatalogFailed(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand All @@ -215,7 +220,8 @@ public async Task ConnectionRetryOpenAsyncInvalidCatalogFailed(string cnnString,
deltaTime: TimeSpan.FromMilliseconds(250));

// Test relies on error 4060 for automatic retry, which is not returned when using AAD auth
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.TcpConnectionStringDoesNotUseAadAuth))]
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.TcpConnectionStringDoesNotUseAadAuth), nameof(DataTestUtility.IsNotAzureServer))]
[MemberData(nameof(ConnectionCancelRetryOpenAsyncInvalidCatalog_Data), DisableDiscoveryEnumeration = true)]
public async Task ConnectionCancelRetryOpenAsyncInvalidCatalog(string cnnString, SqlRetryLogicBaseProvider provider)
{
Expand Down
Loading