Skip to content

Fix SupportsIntegratedSecurity Test Configuration #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulmedynski wants to merge 7 commits into
base: main
Choose a base branch
from
+54 −26
Open

Fix SupportsIntegratedSecurity Test Configuration #3887

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5721e54
Test to see if our Integrated Security tests pass when they aren't sk…
paulmedynski Jan 13, 2026
41121a2
Testing if-expression evaluation with bare parameters.
paulmedynski Jan 14, 2026
a72967d
Fixed null checks.
paulmedynski Jan 14, 2026
b912e82
Added more cases.
paulmedynski Jan 14, 2026
5a28ae3
Narrowing down to the string-to-bool conversion.
paulmedynski Jan 14, 2026
b10c349
Root-caused the issue and documented for the future.
paulmedynski Jan 14, 2026
1ac81c6
Disabled the failing NP tests for now.
paulmedynski Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eng/pipelines/common/templates/jobs/ci-run-tests-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ jobs:
buildConfiguration: ${{ parameters.buildConfiguration }}

- ${{ if ne(parameters.configProperties, '{}') }}:
- template: ../steps/if-expression-test.yml@self
parameters:
${{ if parameters.configProperties.SupportsIntegratedSecurity }}:
string1: ${{ parameters.configProperties.SupportsIntegratedSecurity }}
bool1: ${{ eq(parameters.configProperties.SupportsIntegratedSecurity, 'true') }}
bool2: true

- template: ../steps/update-config-file-step.yml@self # update config.json file
parameters:
debug: ${{ parameters.debug }}
Expand Down
27 changes: 27 additions & 0 deletions eng/pipelines/common/templates/steps/if-expression-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
################################################################################
# Licensed to the .NET Foundation under one or more agreements.
# The .NET Foundation licenses this file to you under the MIT license.
# See the LICENSE file in the project root for more information.
################################################################################

parameters:

- name: string1
type: string
default: 'DEFAULT'

- name: bool1
type: boolean
default: false

- name: bool2
type: boolean
default: false

steps:

- pwsh: |
Write-Host "String1: ${{ parameters.string1 }}"
Write-Host "Bool1: ${{ parameters.bool1 }}"
Write-Host "Bool2: ${{ parameters.bool2 }}"
displayName: 'Display Parameters'
10 changes: 5 additions & 5 deletions eng/pipelines/dotnet-sqlclient-ci-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ stages:
NPConnectionString: $(SQL_NP_CONN_STRING)
AzureKeyVaultUrl: $(AzureKeyVaultUrl)
AzureKeyVaultTenantId: $(AzureKeyVaultTenantId)
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)
SupportsIntegratedSecurity: NOT_A_BOOL
UserManagedIdentityClientId: $(UserManagedIdentityClientId)
FileStreamDirectory: $(FileStreamDirectory)
LocalDbAppName: $(LocalDbAppName)
Expand Down Expand Up @@ -289,7 +289,7 @@ stages:
NPConnectionString: $(SQL_NP_CONN_STRING)
AzureKeyVaultUrl: $(AzureKeyVaultUrl)
AzureKeyVaultTenantId: $(AzureKeyVaultTenantId)
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)
SupportsIntegratedSecurity: true
UserManagedIdentityClientId: $(UserManagedIdentityClientId)
FileStreamDirectory: $(FileStreamDirectory)
LocalDbAppName: $(LocalDbAppName)
Expand Down Expand Up @@ -318,7 +318,7 @@ stages:
NPConnectionString: $(SQL_NP_CONN_STRING)
AzureKeyVaultUrl: $(AzureKeyVaultUrl)
AzureKeyVaultTenantId: $(AzureKeyVaultTenantId)
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)
SupportsIntegratedSecurity: true
UserManagedIdentityClientId: $(UserManagedIdentityClientId)
FileStreamDirectory: $(FileStreamDirectory)
LocalDbAppName: $(LocalDbAppName)
Expand Down Expand Up @@ -346,7 +346,7 @@ stages:
# config.json properties
TCPConnectionString: $(SQL_TCP_INSTANCE_CONN_STRING)
NPConnectionString: $(SQL_NP_INSTANCE_CONN_STRING)
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)
SupportsIntegratedSecurity: true
# extra config properties
SQLRootPath: $(SQL22RootPath)
instanceName: $(NamedInstance)
Expand Down Expand Up @@ -443,7 +443,7 @@ stages:
AADServicePrincipalSecret: $(AADServicePrincipalSecret)
AzureKeyVaultUrl: $(AzureKeyVaultUrl)
AzureKeyVaultTenantId: $(AzureKeyVaultTenantId)
SupportsIntegratedSecurity: $(SupportsIntegratedSecurity)
SupportsIntegratedSecurity: true
UserManagedIdentityClientId: $(UserManagedIdentityClientId)
AliasName: $(SQLAliasName)
LocalDbAppName: $(LocalDbAppName)
Expand Down
Loading