-
Notifications
You must be signed in to change notification settings - Fork 27
[WIP] Port this to macOS/Linux and add support for other XAML variants #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
2bf1d4e
e4681ad
479b4d8
160672f
1dcda45
79ddbb8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,11 @@ private static void OnAllowDeselectionChanged(DependencyObject obj, DependencyPr | |
| } | ||
| } | ||
|
|
||
| #if UNO | ||
| private static void OnTapped(object sender, Microsoft.UI.Xaml.Input.TappedRoutedEventArgs e) | ||
| #else | ||
| private static void OnTapped(object sender, Windows.UI.Xaml.Input.TappedRoutedEventArgs e) | ||
| #endif | ||
|
Comment on lines
+59
to
+63
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. An easier approach for all these may be global namespaces which we'd need to use later eventually to support both UWP + WinUI 3. |
||
| { | ||
| if (sender is ListBox listBox) | ||
| { | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the Pivot stuff probably isn't even used anymore, the original prototype version from like 2017 used to use Pivot before a change to ListBox, and now NavigationView is used... It may be easier to just remove some of these old things that aren't used anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could just use the fully qualified name for both cases, right? just have a comment as to why. I guess there's some conflict with a similar named class in Uno?